Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update msbuild's property functions #111

Merged
merged 2 commits into from
May 25, 2017
Merged

Update msbuild's property functions #111

merged 2 commits into from
May 25, 2017

Conversation

cdmihai
Copy link
Contributor

@cdmihai cdmihai commented May 9, 2017 •
edited
Loading

No description provided.

@msftclas
Copy link

msftclas commented May 9, 2017

@cdmihai,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@cdmihai
Copy link
Contributor Author

cdmihai commented May 9, 2017

@Microsoft/msbuild-maintainers

rainersigwald
rainersigwald approved these changes May 10, 2017
View reviewed changes
Copy link
Contributor

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @kempb

@cdmihai cdmihai mentioned this pull request May 23, 2017
Closed
@ghogen
Copy link
Collaborator

ghogen commented May 25, 2017

@kempb please review

kempb
kempb suggested changes May 25, 2017
View reviewed changes
Copy link
Contributor

@kempb kempb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes needed - a couple of the function signature descriptions need to have periods added to the ends of the sentences. Aside from that, it looks okay to me.

@cdmihai
Copy link
Contributor Author

cdmihai commented May 25, 2017 •
edited
Loading

@kempb Made the changes and update the text of a function

@kempb kempb merged commit 3f7364a into MicrosoftDocs:master May 25, 2017
@cdmihai cdmihai deleted the patch-1 branch May 25, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

@kempb kempb kempb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cdmihai @msftclas @ghogen @rainersigwald @kempb