Update doc for CA1305 to mention excluded types #5016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Evangelink : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
mavasani
reviewed
Apr 16, 2020
| @@ -35,6 +35,9 @@ This rule ignores calls to .NET methods that are documented as ignoring the <xre | |||
| - <xref:System.Activator.CreateInstance%2A?displayProperty=nameWithType> | |||
| - <xref:System.Resources.ResourceManager.GetObject%2A?displayProperty=nameWithType> | |||
| - <xref:System.Resources.ResourceManager.GetString%2A?displayProperty=nameWithType> | |||
| - <xref:bool.ToString%2A?displayProperty=nameWithType> | |||
| - <xref:char.ToString%2A?displayProperty=nameWithType> | |||
| - <xref:System.Guid.ToString%2A?displayProperty=nameWithType> | |||
There was a problem hiding this comment.
@Evangelink Can you remind me of the PR on roslyn-analyzers to fix this?
There was a problem hiding this comment.
There was a problem hiding this comment.
@mavasani The changes here look OK to merge?
mavasani
approved these changes
Apr 17, 2020
Mikejo5000
approved these changes
Apr 17, 2020
|
#sign-off Thanks for the doc updates, @Evangelink ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4986
This new feature is not yet publicly released. Please sync-up with @mavasani for when to merge this PR.