-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #2056 #2129
Resolves #2056 #2129
Conversation
Fix examples. MicrosoftDocs#2056
Docs Build status updates of commit b3788d4: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 6ab3a71: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@dariomws @get-itips @tseward Peer review needed for this PR. cc @JohanFreelancer9 for copy editing. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with it, only one thing, are we going to leave cmdlet's output on examples? Is this vital for the article? @tseward @dariomws
@get-itips not sure about what we usually do here, but for me looks better without them because you can copy and paste the command succesfully. |
@dariomws @get-itips Some will complain that there is no example of the output of the get command, some that when there is output they cannot copy and paste :) I think it is useful to see the output but somehow be able to copy only the command, though I do not think it is currently possible. |
Maybe we can put the output in the description of the example. @get-itips @velkovb What do you think? |
Has that been done in the past? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy review.
Docs Build status updates of commit d41a188: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit d41a188: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
d41a188
to
7630f12
Compare
Docs Build status updates of commit 7630f12: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
I don't remember It's true, but I saw that some cmdlets have a explanation or example of the output in the cmdlet description section. |
Let's leave it as is.. |
Docs Build status updates of commit 3f0808a: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@get-itips @dariomws So here is what I recently found on the output question: Get-Command -Module Microsoft.PowerShell.Security
I will start doing this in PRs :) |
Testing: Get-Command -Module Microsoft.PowerShell.Security
|
@velkovb like it! Let's try, I think we should be able to copy the command separately in this way. Thanks! |
@dariomws I created a new PR to implement that - #2190 |
Fix examples.
#2056