Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe special identities "This Organization" and "Other Organization" #7586

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cnotin
Copy link
Contributor

@cnotin cnotin commented Nov 8, 2023

"This Organization" was lacking a description, while "Other Organization" had an incorrect description that was copy-pasted from the "Dialup" special identity.

Descriptions are copied from https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2003/cc755321(v=ws.10)#how-selective-authentication-affects-windows-server2003-member-server-authentication

I'm unsure about the best way to link to the "https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2003/cc755321(v=ws.10)#how-selective-authentication-affects-domain-controller-behavior" article that I mentioned but I trust that the maintainers will know :)

Copy link
Contributor

@cnotin : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit c25b2f2:

⚠️ Validation status: warnings

File Status Preview URL Details
WindowsServerDocs/identity/ad-ds/manage/understand-special-identities-groups.md ⚠️Warning Details

WindowsServerDocs/identity/ad-ds/manage/understand-special-identities-groups.md

  • Line 330, Column 6: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2003/cc755321(v=ws.10)#how-selective-authentication-affects-domain-controller-behavior' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 454, Column 6: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2003/cc755321(v=ws.10)#how-selective-authentication-affects-domain-controller-behavior' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 330, Column 6: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2003/cc755321(v=ws.10)#how-selective-authentication-affects-domain-controller-behavior' will be broken in isolated environments. Replace with a relative link.
  • Line 454, Column 6: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2003/cc755321(v=ws.10)#how-selective-authentication-affects-domain-controller-behavior' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 127ea1e:

✅ Validation status: passed

File Status Preview URL Details
WindowsServerDocs/identity/ad-ds/manage/understand-special-identities-groups.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Nov 8, 2023

@robinharwood, @Xelu86

Can you review the proposed changes?

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants