Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows-server-2016-improvements.md #7728

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JoshMoraDSE
Copy link

Through testing, backed up by code review, I've confirmed that GP processing on it's own is not enough to make the w32time service become aware of UtilizeSslTimeData changes, as this value is only ready at service/thread startup. Current wording is a bit misleading, suggests the GP Client will become aware of the change and that alone is enough for changes to take effect, which is not true.

Through testing, backed up by code review, I've confirmed that GP processing on it's own is not enough to make the w32time service become aware of UtilizeSslTimeData changes, as this value is only ready at service/thread startup. Current wording is a bit misleading, suggests the GP Client will become aware of the change and that alone is enough for changes to take effect, which is not true.
Copy link
Contributor

@JoshMoraDSE : Thanks for your contribution! The author(s) have been notified to review your proposed change. @dahavey

Copy link
Contributor

Learn Build status updates of commit c324124:

✅ Validation status: passed

File Status Preview URL Details
WindowsServerDocs/networking/windows-time-service/windows-server-2016-improvements.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Feb 13, 2024

#assign: @robinharwood, @Xelu86

@robinharwood @Xelu86
Can you review the proposed changes?

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Feb 13, 2024
Copy link
Contributor

Learn Build status updates of commit 8c94ec6:

✅ Validation status: passed

File Status Preview URL Details
WindowsServerDocs/networking/windows-time-service/windows-server-2016-improvements.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@JoshMoraDSE
Copy link
Author

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @dahavey

@Jak-MS
Copy link
Contributor

Jak-MS commented Apr 18, 2024

nudge @robinharwood @Xelu86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants