Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more examples which could be included in the explainer #388

Closed
alice opened this issue Aug 18, 2020 · 2 comments
Closed

Some more examples which could be included in the explainer #388

alice opened this issue Aug 18, 2020 · 2 comments
Assignees

Comments

@alice
Copy link

alice commented Aug 18, 2020

Coming here from the TAG review thread

  • It would be helpful to illustrate when the geometrychange event would be more useful than the CSS environment variables - the existing example seems like it would be better handled by the CSS environment variables. @kenchris noted that canvas-based UIs would be one example of where you'd need to set a position directly.
  • Also, in that example it's not clear how the author knows that the search box is on the same side of the split-screen as the keyboard - could this be included in the example code?
@BoCupp-Microsoft
Copy link
Contributor

@alice I've recently updated the explainer. I've added an example for a canvas-based spreadsheet which would be a good candidate for using the JS APIs. Additionally, I've provided a more complete example using CSS environment variables to detect when to adjust elements of the UI based on whether the virtual keyboard is appearing on a particular screen. Please take a look when you have a moment. Thanks!

@snianu
Copy link
Member

snianu commented Nov 19, 2020

TAG reviewed the explainers and the discussions we had in TPAC and supported the proposal.

@snianu snianu closed this as completed Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants