Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package contains debug build of core assembly #1255

Closed
cremor opened this issue May 5, 2021 · 2 comments
Closed

NuGet package contains debug build of core assembly #1255

cremor opened this issue May 5, 2021 · 2 comments
Labels
bug Something isn't working tracked We are tracking this work internally.

Comments

@cremor
Copy link

cremor commented May 5, 2021

Description
The assembly "Microsoft.Web.WebView2.Core.dll" in the current NuGet package (version 1.0.818.41) is a debug build.

Version
SDK: 1.0.818.41
Runtime: 90.0.818.51
Framework: WPF and WinForms
OS: Windows 10

Repro Steps

  1. Download the NuGet package.
  2. Check the assemblies, e.g. the DebuggableAttribute with ILSpy

Additional context
The AssemblyConfigurationAttribute actually says "Release", but the DebuggableAttribute indicates a debug build:

[assembly: Debuggable(DebuggableAttribute.DebuggingModes.Default | DebuggableAttribute.DebuggingModes.DisableOptimizations | DebuggableAttribute.DebuggingModes.IgnoreSymbolStoreSequencePoints | DebuggableAttribute.DebuggingModes.EnableEditAndContinue)]

Both the .NET Framework and the .NET Core assemblies are affected.
ILSpy can't show the value of the DebuggableAttribute of the .NET Core assembly, but if you inspect its assembly attributes during runtime you can see that it has the same flags set as the .NET Framework assembly.

AB#33102770

@cremor cremor added the bug Something isn't working label May 5, 2021
@champnic champnic added the tracked We are tracking this work internally. label May 5, 2021
@champnic
Copy link
Member

champnic commented May 5, 2021

Thanks for catching this - I've opened a bug on our backlog and we'll get it fixed.

@champnic champnic added tracked We are tracking this work internally. and removed tracked We are tracking this work internally. labels May 5, 2021
@champnic
Copy link
Member

champnic commented Aug 3, 2021

This is fixed in 1.0.955-prerelease SDK package. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tracked We are tracking this work internally.
Projects
None yet
Development

No branches or pull requests

2 participants