Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem/Bug]: NuGet package contains debug build assemblies #4409

Closed
cremor opened this issue Mar 6, 2024 · 5 comments
Closed

[Problem/Bug]: NuGet package contains debug build assemblies #4409

cremor opened this issue Mar 6, 2024 · 5 comments
Assignees
Labels
bug Something isn't working regression Something used to work but doesn't anymore tracked We are tracking this work internally.

Comments

@cremor
Copy link

cremor commented Mar 6, 2024

What happened?

The assemblies "Microsoft.Web.WebView2.WinForms.dll" and "Microsoft.Web.WebView2.Wpf.dll" in the current NuGet package (version 1.0.2365.46) are debug builds.

Importance

Moderate. My app's user experience is affected, but still usable.

Runtime Channel

Stable release (WebView2 Runtime)

Runtime Version

not relevant

SDK Version

1.0.2365.46

Framework

Other

Operating System

Other

OS Version

not relevant

Repro steps

  1. Download the NuGet package.
  2. Check the assemblies, e.g. the DebuggableAttribute with ILSpy.

The AssemblyConfigurationAttribute says "Release", but the DebuggableAttribute indicates a debug build:

[assembly: Debuggable(DebuggableAttribute.DebuggingModes.Default | DebuggableAttribute.DebuggingModes.DisableOptimizations | DebuggableAttribute.DebuggingModes.IgnoreSymbolStoreSequencePoints | DebuggableAttribute.DebuggingModes.EnableEditAndContinue)]

Both the .NET Framework and the .NET Core assemblies are affected.
Only the WinForms and WPF assemblies are affected, the Core assembly is fine.

Similar to #1255 and #1406

Repros in Edge Browser

No, issue does not reproduce in the corresponding Edge version

Regression

Regression in newer SDK

Last working version (if regression)

don't know the latest good version, but 1.0.955 was good for sure

AB#49323951

@cremor cremor added the bug Something isn't working label Mar 6, 2024
@github-actions github-actions bot added the regression Something used to work but doesn't anymore label Mar 6, 2024
@lflores-ms lflores-ms assigned oggy22 and unassigned vbryh-msft and lflores-ms Mar 6, 2024
@oggy22
Copy link
Member

oggy22 commented Mar 6, 2024

Hi @cremor! Thanks for reporting this. Would you mind checking older versions so we can get a sense of when the bug was introduced? Thanks!

@oggy22
Copy link
Member

oggy22 commented Mar 6, 2024

Ok, I did some investigation myself and it seems that the problem was introduced between 2164 and 2194. It means that:
1.0.2164-prerelease - good
1.0.2194-prerelease - bad
This was 4-5 months ago which gives us pretty good idea what may have caused it.

@oggy22 oggy22 added the tracked We are tracking this work internally. label Mar 6, 2024
@oggy22
Copy link
Member

oggy22 commented Mar 7, 2024

The fix is on the way. It will likely be included in the next release in ~2 weeks.

@oggy22
Copy link
Member

oggy22 commented Mar 11, 2024

The fix is checked in and the next round of release and prerelease SDKs should have it, ~late March. Closing this bug.

@oggy22 oggy22 closed this as completed Mar 11, 2024
@oggy22
Copy link
Member

oggy22 commented Mar 25, 2024

The fixes are in the latest release and prerleease packages https://www.nuget.org/packages/Microsoft.Web.WebView2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something used to work but doesn't anymore tracked We are tracking this work internally.
Projects
None yet
Development

No branches or pull requests

4 participants