-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hasAuthorityComponent to CustomSchemeRegistration #2465
Merged
yildirimcagri-msft
merged 11 commits into
main
from
api-review-custom-scheme-registration-update
Jun 15, 2022
Merged
Add hasAuthorityComponent to CustomSchemeRegistration #2465
yildirimcagri-msft
merged 11 commits into
main
from
api-review-custom-scheme-registration-update
Jun 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the authority component flag to custom scheme registration.
yildirimcagri-msft
added
the
API Proposal Review
WebView2 API Proposal for review.
label
May 17, 2022
Added more clarification on how the HasAuthorityComponent flag works.
david-risney
requested changes
May 24, 2022
Co-authored-by: David Risney <dave@deletethis.net>
Co-authored-by: David Risney <dave@deletethis.net>
Co-authored-by: David Risney <dave@deletethis.net>
oldnewthing
reviewed
Jun 2, 2022
FrankC-msft
reviewed
Jun 3, 2022
FrankC-msft
reviewed
Jun 3, 2022
FrankC-msft
reviewed
Jun 3, 2022
MikeHillberg
reviewed
Jun 6, 2022
david-risney
requested changes
Jun 6, 2022
yildirimcagri-msft
deleted the
api-review-custom-scheme-registration-update
branch
June 15, 2022 13:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the authority component flag to custom scheme registration as this needs to be known up front for registration.