Add spec for StartInBackgroundMode.md #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephJin0815
changed the title
david-risney
requested changes
Sep 10, 2022
aluhrs13
reviewed
Sep 12, 2022
david-risney
requested changes
Sep 16, 2022
david-risney
requested changes
Sep 26, 2022
david-risney
requested changes
Sep 30, 2022
specs/StartInBackgroundMode.md
Outdated
| /// Set `CreationPriority` to `COREWEBVIEW2_CREATION_PRIORITY_HIGH` will attempt to | ||
| /// create the WebView2 browser process with high priority. | ||
| /// Default is `COREWEBVIEW2_CREATION_PRIORITY_HIGH`. | ||
| /// Note that 1)The host app's priority must be at least normal for |
There was a problem hiding this comment.
Suggested change
| /// Note that 1)The host app's priority must be at least normal for | |
| /// Note that the host app's priority must be at least normal for | |
specs/StartInBackgroundMode.md
Outdated
| /// create the WebView2 browser process with high priority. | ||
| /// Default is `COREWEBVIEW2_CREATION_PRIORITY_HIGH`. | ||
| /// Note that 1)The host app's priority must be at least normal for | ||
| /// `COREWEBVIEW2_CREATION_PRIORITY_HIGH` to be applied. Else, the WebView2 browser process |
There was a problem hiding this comment.
Suggested change
| /// `COREWEBVIEW2_CREATION_PRIORITY_HIGH` to be applied. Else, the WebView2 browser process | |
| /// `COREWEBVIEW2_CREATION_PRIORITY_HIGH` to be applied. Otherwise the WebView2 browser process | |
specs/StartInBackgroundMode.md
Outdated
| /// Note that 1)The host app's priority must be at least normal for | ||
| /// `COREWEBVIEW2_CREATION_PRIORITY_HIGH` to be applied. Else, the WebView2 browser process | ||
| /// still get created with normal priority even with `COREWEBVIEW2_CREATION_PRIORITY_HIGH` setting. | ||
| /// 2)Currently `CreationPriority` only applies to the creation of the WebView2 browser process. |
There was a problem hiding this comment.
Suggested change
| /// 2)Currently `CreationPriority` only applies to the creation of the WebView2 browser process. | |
| /// Additionally, currently `CreationPriority` only applies to the creation of the WebView2 browser process. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the review for the new StartInBackgroundMode API.