Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Spec: Web Notification #3049

Merged
merged 17 commits into from
Feb 3, 2023
Merged

API Spec: Web Notification #3049

merged 17 commits into from
Feb 3, 2023

Conversation

peiche-jessica
Copy link
Collaborator

No description provided.

@peiche-jessica peiche-jessica added the API Proposal Review WebView2 API Proposal for review. label Dec 9, 2022
david-risney
david-risney requested changes Dec 9, 2022
View reviewed changes
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
@peiche-jessica
Copy link
Collaborator Author

TODO: update sample code to reflect async ReportClicked and ReportClosed.

david-risney
david-risney requested changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@david-risney david-risney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional feedback. Should be good after addressing this. Please fix these issues, finish this PR, open a new PR to main, let me know, and I will schedule a review. Thanks.

specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
specs/WebNotification.md Outdated Show resolved Hide resolved
@peiche-jessica peiche-jessica merged commit 4493c00 into api-notification Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-risney david-risney david-risney requested changes

Assignees
No one assigned
Labels
API Proposal Review WebView2 API Proposal for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peiche-jessica @david-risney