Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore streamlined Readmes for Win32, WinForms, & WPF #194

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Restore streamlined Readmes for Win32, WinForms, & WPF #194

merged 3 commits into from
Jun 2, 2023

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented May 30, 2023 •
edited
Loading

This PR streamlines the main, Win32 sample's Readme like the other Readmes.

  • It links to the full, detailed article in the regular docs.
  • Updates the screenshot of the app.

This PR restores 3 Readmes for Samples from PR 140, since they were overwritten by PR 152:

Related Docs PR: MicrosoftDocs/edge-developer#2614 - improves article for Win32 sample.

@mikehoffms mikehoffms marked this pull request as draft May 30, 2023 23:10
@mikehoffms mikehoffms mentioned this pull request May 31, 2023
Merged
@mikehoffms mikehoffms marked this pull request as ready for review June 1, 2023 21:30
@mikehoffms mikehoffms changed the title Streamline Win32 sample Readme, update screenshot Restore streamlined Readmes for Win32, WinForms, & WPF Jun 1, 2023
@peiche-jessica
Copy link
Collaborator

Are we migrating the content we removed from README anywhere? We had the intention of giving an overview of the files in the sample app project.

@mikehoffms
Copy link
Contributor Author

mikehoffms commented Jun 2, 2023 •
edited
Loading

@peiche-jessica

Are we migrating the content we removed from README anywhere? We had the intention of giving an overview of the files in the sample app project.

Yes that was done back in Sep 2022 when doing PR 140.
live site:
https://learn.microsoft.com/en-us/microsoft-edge/webview2/samples/webview2apissample#application-architecture
That bottom part of the article has near-identical markup as the verbose Readme page.

Improvements on that page are in an open PR:
MicrosoftDocs/edge-developer#2614
gh rendered:
https://github.com/mikehoffms/edge-developer/blob/user/mikehoffms/win32-sample-readme/microsoft-edge/webview2/samples/webview2apissample.md#hybrid-app-architecture

@peiche-jessica peiche-jessica merged commit d0cad11 into MicrosoftEdge:main Jun 2, 2023
1 check passed
peiche-jessica pushed a commit that referenced this pull request Jun 13, 2023
@mikehoffms @peiche-jessica
Restore streamlined Readmes for Win32, WinForms, & WPF (#194)
dd3ccca 
* Streamline Readme, update screenshot

* Restore changes from PR 140

* Restore Readme WinForms & WPF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peiche-jessica peiche-jessica peiche-jessica approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikehoffms @peiche-jessica