Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebRTC function Can I custom the "Screen Sharing dialog" #940

Closed
lamposu opened this issue Feb 16, 2021 · 10 comments
Closed

WebRTC function Can I custom the "Screen Sharing dialog" #940

lamposu opened this issue Feb 16, 2021 · 10 comments
Labels
bug Something isn't working tracked We are tracking this work internally.

Comments

@lamposu
Copy link

lamposu commented Feb 16, 2021

Hello,

When using the webrtc function to sharing the desktop.

getUserMedia()

The following dialog will open, i want to known is there any way to customize it or can i remove the "Microsoft Edge tab"? Thanks.

image

"Microsoft Edge" bug: AB#31758014
Edit title scenario: AB#31827415

@champnic champnic added bug Something isn't working tracked We are tracking this work internally. and removed question labels Feb 18, 2021
@champnic
Copy link
Member

Hey @lamposu - This is a bug that it is showing up, and we'll definitely get this removed. I've opened a bug on our backlog to track - thanks for catching this!

@lamposu
Copy link
Author

lamposu commented Feb 18, 2021

@champnic Thanks for your quickly response.
It would be nice if you can provide a way to modify the above text description: “xxxx wants to share the contents of your screen...”

@champnic
Copy link
Member

champnic commented Feb 19, 2021

What is that showing for you today? (ie what is the 'xxxx'?)

@lamposu
Copy link
Author

lamposu commented Feb 22, 2021

"xxxx" is the webpage host domain name, like "www.webrtcserver.com".
I want to put my own string on this place.

@champnic
Copy link
Member

Gotcha - I'll open that as a separate feature request on our backlog. Thanks!

@lamposu
Copy link
Author

lamposu commented Feb 25, 2021

Hopefully these features will be available soon. Thanks!

@champnic
Copy link
Member

champnic commented May 4, 2021

The "Microsoft Edge" bug should be fixed in runtimes 91.0.826.0+. Thanks!

@champnic champnic closed this as completed May 4, 2021
@champnic champnic reopened this May 4, 2021
@champnic
Copy link
Member

champnic commented May 4, 2021

For the remaining part, the "x wants to share...", we are just going to hide that text in the dialog when in a WebView2 app.

@lamposu
Copy link
Author

lamposu commented May 10, 2021

Good news, Thanks.

@champnic
Copy link
Member

champnic commented Jun 5, 2021

The text has been removed in runtimes 92.0.889.0+. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tracked We are tracking this work internally.
Projects
None yet
Development

No branches or pull requests

2 participants