Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library view on web app can navigate above audiofolders directory on future3 #2224

Closed
thecyborganizer opened this issue Jan 31, 2024 · 4 comments · Fixed by #2293
Closed
Assignees
Labels
bug future3 Relates to future3 development needs triage
Milestone

Comments

@thecyborganizer
Copy link

thecyborganizer commented Jan 31, 2024

Describe your problem

In the web app, if you choose the "folders" view, once you start navigating into the directory structure, you can use the "back" button to go above the audiofolders directory, all the way up to the home directory of the user.

This exposes the whole filesystem of the host device to the web app, which might not always be desirable.

See below for a screen recording demonstrating this behavior:

Screencast.2024-01-31.14.55.45.mp4

What's your hardware set up?

Raspberry Pi Zero 2 W running 3.4.0

If possible, try to attach logs from ... (paths from RPi)

31.01.2024 14:49:54 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': './'})
31.01.2024 14:49:54 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:49:54 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'directory', 'name': 'test', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/test'}, {'type': 'directory', 'name': 'They Might Be Giants', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants'}, {'type': 'file', 'name': '02-Birdhouse in Your Soul.mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/02-Birdhouse in Your Soul.mp3'}, {'type': 'file', 'name': 'Offenbach: Can Can - Orpheus in the Underworld - Awesome Youth Symphony Orchestra [Tmm8fP1-_ww].mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/Offenbach: Can Can - Orpheus in the Underworld - Awesome Youth Symphony Orchestra [Tmm8fP1-_ww].mp3'}, {'type': 'file', 'name': 'Pokémon Theme Song [JuYeHPFR3f0].mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/Pokémon Theme Song [JuYeHPFR3f0].mp3'}, {'type': 'file', 'name': 'Radetzky March.mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/Radetzky March.mp3'}, {'type': 'file', 'name': 'The Fox (What Does the Fox Say?) [W20gcM6_UtQ].mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/The Fox (What Does the Fox Say?) [W20gcM6_UtQ].mp3'}], 'id': '0e011d71-0ab6-4598-a755-522d4fa0555d'}
31.01.2024 14:49:56 -  114:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Request: {'id': 'f5c963a9-5c61-48ba-a20d-553e2d4a5f3d', 'package': 'player', 'plugin': 'ctrl', 'method': 'get_folder_content', 'kwargs': {'folder': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants'}}
31.01.2024 14:49:56 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants'})
31.01.2024 14:49:56 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:49:56 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'directory', 'name': 'Flood', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/Flood'}, {'type': 'directory', 'name': 'The Else', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else'}], 'id': 'f5c963a9-5c61-48ba-a20d-553e2d4a5f3d'}
31.01.2024 14:49:57 -  114:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Request: {'id': 'b14ea468-8d9c-4034-967a-1bf202ef97c0', 'package': 'player', 'plugin': 'ctrl', 'method': 'get_folder_content', 'kwargs': {'folder': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders'}}
31.01.2024 14:49:57 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders'})
31.01.2024 14:49:57 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:49:57 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'directory', 'name': 'test', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/test'}, {'type': 'directory', 'name': 'They Might Be Giants', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants'}, {'type': 'file', 'name': '02-Birdhouse in Your Soul.mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/02-Birdhouse in Your Soul.mp3'}, {'type': 'file', 'name': 'Offenbach: Can Can - Orpheus in the Underworld - Awesome Youth Symphony Orchestra [Tmm8fP1-_ww].mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/Offenbach: Can Can - Orpheus in the Underworld - Awesome Youth Symphony Orchestra [Tmm8fP1-_ww].mp3'}, {'type': 'file', 'name': 'Pokémon Theme Song [JuYeHPFR3f0].mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/Pokémon Theme Song [JuYeHPFR3f0].mp3'}, {'type': 'file', 'name': 'Radetzky March.mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/Radetzky March.mp3'}, {'type': 'file', 'name': 'The Fox (What Does the Fox Say?) [W20gcM6_UtQ].mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/The Fox (What Does the Fox Say?) [W20gcM6_UtQ].mp3'}], 'id': 'b14ea468-8d9c-4034-967a-1bf202ef97c0'}
31.01.2024 14:49:58 -  114:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Request: {'id': '84c23c93-29c5-4bce-8681-c9e62bcbc766', 'package': 'player', 'plugin': 'ctrl', 'method': 'get_folder_content', 'kwargs': {'folder': '/home/admin/RPi-Jukebox-RFID/shared'}}
31.01.2024 14:49:58 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': '/home/admin/RPi-Jukebox-RFID/shared'})
31.01.2024 14:49:58 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:49:58 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'directory', 'name': 'audiofolders', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders'}, {'type': 'directory', 'name': 'logs', 'path': '/home/admin/RPi-Jukebox-RFID/shared/logs'}, {'type': 'directory', 'name': 'playlists', 'path': '/home/admin/RPi-Jukebox-RFID/shared/playlists'}, {'type': 'directory', 'name': 'settings', 'path': '/home/admin/RPi-Jukebox-RFID/shared/settings'}], 'id': '84c23c93-29c5-4bce-8681-c9e62bcbc766'}
31.01.2024 14:49:59 -  114:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Request: {'id': '4ae7ae5b-cb86-41a9-8803-3e67def6d366', 'package': 'player', 'plugin': 'ctrl', 'method': 'get_folder_content', 'kwargs': {'folder': '/home/admin/RPi-Jukebox-RFID'}}
31.01.2024 14:49:59 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': '/home/admin/RPi-Jukebox-RFID'})
31.01.2024 14:49:59 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:49:59 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'directory', 'name': '.git', 'path': '/home/admin/RPi-Jukebox-RFID/.git'}, {'type': 'directory', 'name': '.githooks', 'path': '/home/admin/RPi-Jukebox-RFID/.githooks'}, {'type': 'directory', 'name': '.github', 'path': '/home/admin/RPi-Jukebox-RFID/.github'}, {'type': 'directory', 'name': '.venv', 'path': '/home/admin/RPi-Jukebox-RFID/.venv'}, {'type': 'directory', 'name': 'ci', 'path': '/home/admin/RPi-Jukebox-RFID/ci'}, {'type': 'directory', 'name': 'docker', 'path': '/home/admin/RPi-Jukebox-RFID/docker'}, {'type': 'directory', 'name': 'documentation', 'path': '/home/admin/RPi-Jukebox-RFID/documentation'}, {'type': 'directory', 'name': 'installation', 'path': '/home/admin/RPi-Jukebox-RFID/installation'}, {'type': 'directory', 'name': 'resources', 'path': '/home/admin/RPi-Jukebox-RFID/resources'}, {'type': 'directory', 'name': 'shared', 'path': '/home/admin/RPi-Jukebox-RFID/shared'}, {'type': 'directory', 'name': 'src', 'path': '/home/admin/RPi-Jukebox-RFID/src'}, {'type': 'directory', 'name': 'test', 'path': '/home/admin/RPi-Jukebox-RFID/test'}, {'type': 'file', 'name': 'CODE_OF_CONDUCT.md', 'path': '/home/admin/RPi-Jukebox-RFID/CODE_OF_CONDUCT.md'}, {'type': 'file', 'name': 'CONTRIBUTING.md', 'path': '/home/admin/RPi-Jukebox-RFID/CONTRIBUTING.md'}, {'type': 'file', 'name': 'pytest.ini', 'path': '/home/admin/RPi-Jukebox-RFID/pytest.ini'}, {'type': 'file', 'name': 'README.md', 'path': '/home/admin/RPi-Jukebox-RFID/README.md'}, {'type': 'file', 'name': 'run_flake8.sh', 'path': '/home/admin/RPi-Jukebox-RFID/run_flake8.sh'}, {'type': 'file', 'name': 'run_pytest.sh', 'path': '/home/admin/RPi-Jukebox-RFID/run_pytest.sh'}], 'id': '4ae7ae5b-cb86-41a9-8803-3e67def6d366'}
31.01.2024 14:50:01 -  114:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Request: {'id': 'aa0f3af3-d9c2-497a-8e28-f60582a9ad96', 'package': 'player', 'plugin': 'ctrl', 'method': 'get_folder_content', 'kwargs': {'folder': './'}}
31.01.2024 14:50:01 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': './'})
31.01.2024 14:50:01 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:50:01 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'directory', 'name': 'test', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/test'}, {'type': 'directory', 'name': 'They Might Be Giants', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants'}, {'type': 'file', 'name': '02-Birdhouse in Your Soul.mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/02-Birdhouse in Your Soul.mp3'}, {'type': 'file', 'name': 'Offenbach: Can Can - Orpheus in the Underworld - Awesome Youth Symphony Orchestra [Tmm8fP1-_ww].mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/Offenbach: Can Can - Orpheus in the Underworld - Awesome Youth Symphony Orchestra [Tmm8fP1-_ww].mp3'}, {'type': 'file', 'name': 'Pokémon Theme Song [JuYeHPFR3f0].mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/Pokémon Theme Song [JuYeHPFR3f0].mp3'}, {'type': 'file', 'name': 'Radetzky March.mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/Radetzky March.mp3'}, {'type': 'file', 'name': 'The Fox (What Does the Fox Say?) [W20gcM6_UtQ].mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/The Fox (What Does the Fox Say?) [W20gcM6_UtQ].mp3'}], 'id': 'aa0f3af3-d9c2-497a-8e28-f60582a9ad96'}
31.01.2024 14:55:29 -  114:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Request: {'id': 'fde37b07-edb8-499a-b794-c2be3c24469e', 'package': 'player', 'plugin': 'ctrl', 'method': 'get_folder_content', 'kwargs': {'folder': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants'}}
31.01.2024 14:55:29 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants'})
31.01.2024 14:55:29 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:55:29 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'directory', 'name': 'Flood', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/Flood'}, {'type': 'directory', 'name': 'The Else', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else'}], 'id': 'fde37b07-edb8-499a-b794-c2be3c24469e'}
31.01.2024 14:55:30 -  114:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Request: {'id': 'aae949c5-ce1e-427d-bd94-24974c8abc09', 'package': 'player', 'plugin': 'ctrl', 'method': 'get_folder_content', 'kwargs': {'folder': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else'}}
31.01.2024 14:55:30 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else'})
31.01.2024 14:55:30 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:55:30 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'file', 'name': "01 I'm Impressed.m4a", 'path': "/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else/01 I'm Impressed.m4a"}, {'type': 'file', 'name': '02 Take Out The Trash.m4a', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else/02 Take Out The Trash.m4a'}, {'type': 'file', 'name': '03 Upside Down Frown.m4a', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else/03 Upside Down Frown.m4a'}, {'type': 'file', 'name': '04 Climbing The Walls.m4a', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else/04 Climbing The Walls.m4a'}, {'type': 'file', 'name': '05 Careful What You Pack.m4a', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else/05 Careful What You Pack.m4a'}, {'type': 'file', 'name': "06 The Cap'm.m4a", 'path': "/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else/06 The Cap'm.m4a"}, {'type': 'file', 'name': '07 With The Dark.m4a', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else/07 With The Dark.m4a'}, {'type': 'file', 'name': '08 The Shadow Government.m4a', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else/08 The Shadow Government.m4a'}, {'type': 'file', 'name': '09 Bee Of The Bird Of The Moth.m4a', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else/09 Bee Of The Bird Of The Moth.m4a'}, {'type': 'file', 'name': '10 Withered Hope.m4a', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else/10 Withered Hope.m4a'}, {'type': 'file', 'name': '11 Contrecoup.m4a', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else/11 Contrecoup.m4a'}, {'type': 'file', 'name': '12 Feign Amnesia.m4a', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else/12 Feign Amnesia.m4a'}, {'type': 'file', 'name': '13 The Mesopotamians.m4a', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else/13 The Mesopotamians.m4a'}], 'id': 'aae949c5-ce1e-427d-bd94-24974c8abc09'}
31.01.2024 14:55:32 -  114:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Request: {'id': '4caeffc2-122c-4bf2-903a-092b0e8afe40', 'package': 'player', 'plugin': 'ctrl', 'method': 'get_folder_content', 'kwargs': {'folder': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants'}}
31.01.2024 14:55:32 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants'})
31.01.2024 14:55:32 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:55:32 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'directory', 'name': 'Flood', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/Flood'}, {'type': 'directory', 'name': 'The Else', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants/The Else'}], 'id': '4caeffc2-122c-4bf2-903a-092b0e8afe40'}
31.01.2024 14:55:33 -  114:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Request: {'id': 'a7ea22ac-e357-488d-9001-c4de86691651', 'package': 'player', 'plugin': 'ctrl', 'method': 'get_folder_content', 'kwargs': {'folder': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders'}}
31.01.2024 14:55:33 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders'})
31.01.2024 14:55:33 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:55:33 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'directory', 'name': 'test', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/test'}, {'type': 'directory', 'name': 'They Might Be Giants', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/They Might Be Giants'}, {'type': 'file', 'name': '02-Birdhouse in Your Soul.mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/02-Birdhouse in Your Soul.mp3'}, {'type': 'file', 'name': 'Offenbach: Can Can - Orpheus in the Underworld - Awesome Youth Symphony Orchestra [Tmm8fP1-_ww].mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/Offenbach: Can Can - Orpheus in the Underworld - Awesome Youth Symphony Orchestra [Tmm8fP1-_ww].mp3'}, {'type': 'file', 'name': 'Pokémon Theme Song [JuYeHPFR3f0].mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/Pokémon Theme Song [JuYeHPFR3f0].mp3'}, {'type': 'file', 'name': 'Radetzky March.mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/Radetzky March.mp3'}, {'type': 'file', 'name': 'The Fox (What Does the Fox Say?) [W20gcM6_UtQ].mp3', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders/The Fox (What Does the Fox Say?) [W20gcM6_UtQ].mp3'}], 'id': 'a7ea22ac-e357-488d-9001-c4de86691651'}
31.01.2024 14:55:34 -  114:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Request: {'id': '74ba0656-ae60-4d08-b9c4-5eac151fe2cc', 'package': 'player', 'plugin': 'ctrl', 'method': 'get_folder_content', 'kwargs': {'folder': '/home/admin/RPi-Jukebox-RFID/shared'}}
31.01.2024 14:55:34 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': '/home/admin/RPi-Jukebox-RFID/shared'})
31.01.2024 14:55:34 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:55:34 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'directory', 'name': 'audiofolders', 'path': '/home/admin/RPi-Jukebox-RFID/shared/audiofolders'}, {'type': 'directory', 'name': 'logs', 'path': '/home/admin/RPi-Jukebox-RFID/shared/logs'}, {'type': 'directory', 'name': 'playlists', 'path': '/home/admin/RPi-Jukebox-RFID/shared/playlists'}, {'type': 'directory', 'name': 'settings', 'path': '/home/admin/RPi-Jukebox-RFID/shared/settings'}], 'id': '74ba0656-ae60-4d08-b9c4-5eac151fe2cc'}
31.01.2024 14:55:34 -  114:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Request: {'id': '954b4029-fe3f-48ba-b1ba-22cb3025a401', 'package': 'player', 'plugin': 'ctrl', 'method': 'get_folder_content', 'kwargs': {'folder': '/home/admin/RPi-Jukebox-RFID'}}
31.01.2024 14:55:34 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': '/home/admin/RPi-Jukebox-RFID'})
31.01.2024 14:55:34 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:55:34 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'directory', 'name': '.git', 'path': '/home/admin/RPi-Jukebox-RFID/.git'}, {'type': 'directory', 'name': '.githooks', 'path': '/home/admin/RPi-Jukebox-RFID/.githooks'}, {'type': 'directory', 'name': '.github', 'path': '/home/admin/RPi-Jukebox-RFID/.github'}, {'type': 'directory', 'name': '.venv', 'path': '/home/admin/RPi-Jukebox-RFID/.venv'}, {'type': 'directory', 'name': 'ci', 'path': '/home/admin/RPi-Jukebox-RFID/ci'}, {'type': 'directory', 'name': 'docker', 'path': '/home/admin/RPi-Jukebox-RFID/docker'}, {'type': 'directory', 'name': 'documentation', 'path': '/home/admin/RPi-Jukebox-RFID/documentation'}, {'type': 'directory', 'name': 'installation', 'path': '/home/admin/RPi-Jukebox-RFID/installation'}, {'type': 'directory', 'name': 'resources', 'path': '/home/admin/RPi-Jukebox-RFID/resources'}, {'type': 'directory', 'name': 'shared', 'path': '/home/admin/RPi-Jukebox-RFID/shared'}, {'type': 'directory', 'name': 'src', 'path': '/home/admin/RPi-Jukebox-RFID/src'}, {'type': 'directory', 'name': 'test', 'path': '/home/admin/RPi-Jukebox-RFID/test'}, {'type': 'file', 'name': 'CODE_OF_CONDUCT.md', 'path': '/home/admin/RPi-Jukebox-RFID/CODE_OF_CONDUCT.md'}, {'type': 'file', 'name': 'CONTRIBUTING.md', 'path': '/home/admin/RPi-Jukebox-RFID/CONTRIBUTING.md'}, {'type': 'file', 'name': 'pytest.ini', 'path': '/home/admin/RPi-Jukebox-RFID/pytest.ini'}, {'type': 'file', 'name': 'README.md', 'path': '/home/admin/RPi-Jukebox-RFID/README.md'}, {'type': 'file', 'name': 'run_flake8.sh', 'path': '/home/admin/RPi-Jukebox-RFID/run_flake8.sh'}, {'type': 'file', 'name': 'run_pytest.sh', 'path': '/home/admin/RPi-Jukebox-RFID/run_pytest.sh'}], 'id': '954b4029-fe3f-48ba-b1ba-22cb3025a401'}
31.01.2024 14:55:35 -  114:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Request: {'id': 'abe1614f-a618-4c61-8561-e9150f23af67', 'package': 'player', 'plugin': 'ctrl', 'method': 'get_folder_content', 'kwargs': {'folder': '/home/admin'}}
31.01.2024 14:55:35 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': '/home/admin'})
31.01.2024 14:55:35 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:55:35 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'directory', 'name': '.cache', 'path': '/home/admin/.cache'}, {'type': 'directory', 'name': '.config', 'path': '/home/admin/.config'}, {'type': 'directory', 'name': '.dotnet', 'path': '/home/admin/.dotnet'}, {'type': 'directory', 'name': '.local', 'path': '/home/admin/.local'}, {'type': 'directory', 'name': '.vscode-server', 'path': '/home/admin/.vscode-server'}, {'type': 'directory', 'name': 'libzmq', 'path': '/home/admin/libzmq'}, {'type': 'directory', 'name': 'Pimoroni', 'path': '/home/admin/Pimoroni'}, {'type': 'directory', 'name': 'RPi-Jukebox-RFID', 'path': '/home/admin/RPi-Jukebox-RFID'}, {'type': 'file', 'name': 'INSTALL-1704723384.log', 'path': '/home/admin/INSTALL-1704723384.log'}, {'type': 'file', 'name': 'The Fox (What Does the Fox Say?) [W20gcM6_UtQ].mp3', 'path': '/home/admin/The Fox (What Does the Fox Say?) [W20gcM6_UtQ].mp3'}], 'id': 'abe1614f-a618-4c61-8561-e9150f23af67'}
31.01.2024 14:55:36 -  114:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Request: {'id': '1721afd1-595c-40c1-b4f4-a00c7ee32569', 'package': 'player', 'plugin': 'ctrl', 'method': 'get_folder_content', 'kwargs': {'folder': '/home'}}
31.01.2024 14:55:36 -  699:plugs.py           - jb.plugin.call       - MainThread      - DEBUG    - Calling: player.ctrl.get_folder_content(args=(), kwargs={'folder': '/home'})
31.01.2024 14:55:36 -  199:playlistgenerator.py - jb.plgen             - MainThread      - DEBUG    - Exclusion regex: '.*\.((zip)|(xcf)|(py)|(db)|(png)|(jpg)|(conf)|(yaml)|(json)|(.*~)|(.*#))$'
31.01.2024 14:55:36 -  154:server.py          - jb.rpc.server        - MainThread      - DEBUG    - Sending response: {'result': [{'type': 'directory', 'name': 'admin', 'path': '/home/admin'}], 'id': '1721afd1-595c-40c1-b4f4-a00c7ee32569'}

`

@thecyborganizer thecyborganizer added bug future3 Relates to future3 development needs triage labels Jan 31, 2024
@s-martin
Copy link
Collaborator

s-martin commented Mar 4, 2024

Sorry for catching up so late.
Can you add the screencast again? At least I can’t play it.

@AlvinSchiller
Copy link
Collaborator

Additional information:
If you navigate in an empty folder, there is no "back" button anymore to navigate back.
You need to switch pages to come back to the top level view

pabera added a commit to pabera/RPi-Jukebox-RFID that referenced this issue Mar 15, 2024
This also allows to go back when folder is empty

Fixes MiczFlor#2224
pabera added a commit that referenced this issue Mar 16, 2024
* bugfix: Stop Back Action at audiofolder root level

This also allows to go back when folder is empty

Fixes #2224

* fix: Flake8 issue

* Remove some minor issues
@s-martin
Copy link
Collaborator

@thecyborganizer
This should be fixed now on future3/develop.

Could you check this?

@pabera pabera self-assigned this Apr 8, 2024
@pabera pabera added this to the v3.6 milestone Apr 8, 2024
@pabera pabera linked a pull request Apr 8, 2024 that will close this issue
@pabera
Copy link
Collaborator

pabera commented Apr 8, 2024

Problem was fixed

@pabera pabera closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug future3 Relates to future3 development needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants