Play startup sound with correct startup volume #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified startup-scripts.sh to execute mpg123 with the configured startup volume from global.conf. The configured volume from global.conf was ignored when playing the startup sound (always played at 100%, which can be extremely loud for kids). Now the configured volume is converted into the correct volume value for mpg123 (100% volume converts into 32768).
s-martin
approved these changes
Oct 23, 2020
|
Thanks! Yes, I tested it with a range of startup volumes and it works fine. |
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified startup-scripts.sh to execute mpg123 with the configured startup volume from global.conf.
The configured volume from global.conf was ignored when playing the startup sound (always played at 100%, which can be extremely loud for kids).
Now the configured volume is converted into the correct volume value for mpg123 (100% volume converts into 32768).