Bookworm Web Interface 403

[AlvinSchiller]

If v2 is installed on Bookworm, on calling the Webinterface it results in a "403 Forbidden".

Setting the executable right for others on the home folder fixes this. Seems that opening a subfolder (htdocs) needs this permissions since Bookworm.

This was also introduced for nginx in V3

RPi-Jukebox-RFID/installation/routines/setup_jukebox_webapp.sh

Lines 78 to 79 in c0d5a20

	# make sure nginx can access the home directory of the user
	sudo chmod o+x /home/pi

Additionally fixed deprecation warnings for "mod_compress"

[coveralls]

Pull Request Test Coverage Report for Build 7066491871

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 76.82%

---

Totals
Change from base Build 6991409517:	0.0%
Covered Lines:	633
Relevant Lines:	824

---

💛 - Coveralls

[AlvinSchiller]

On Bookworm there is another Problem with the "Folders and Files" Tab.
The UI Elements for creating a folder and Upload are not present.

I narrowed it down to this code lines, but not firm enough with php to see a quick fix (and whats the intention)

RPi-Jukebox-RFID/htdocs/manageFilesFolders.php

Lines 283 to 285 in 0457616

	if (array_key_exists($fpost['cardID'], $shortcuts)) {
	$fpost['folder'] = $shortcuts[$fpost['cardID']];
	}

If the lines are removed, the page is loaded correctly and seems also to behave correct.

@s-martin @pabera any idea?

[AlvinSchiller]

ok maybe just a copy paste bug from the CardID UI (dont see why cardid and shortcut should be relevant in this UI) ?

RPi-Jukebox-RFID/htdocs/inc.formCardEdit.php

Lines 49 to 54 in 0457616

	// check if we can preselect an audiofolder if NOT a foldername was posted
	if(! isset($fpost['audiofolder']) OR trim($fpost['audiofolder']) == "") {
	if(array_key_exists($fpost['cardID'], $shortcuts)) {
	$fpost['audiofolder'] = $shortcuts[$fpost['cardID']];
	}
	}

strange it runs prior bookworm without a fault.

[s-martin]

[...]

I narrowed it down to this code lines, but not firm enough with php to see a quick fix (and whats the intention)

RPi-Jukebox-RFID/htdocs/manageFilesFolders.php

Lines 283 to 285 in 0457616

	if (array_key_exists($fpost['cardID'], $shortcuts)) {
	$fpost['folder'] = $shortcuts[$fpost['cardID']];
	}

If the lines are removed, the page is loaded correctly and seems also to behave correct.

@s-martin @pabera any idea?

Do we have some git blame info?

[AlvinSchiller]

Do we have some git blame info?

Nope. Was this way from the very beginning

[AlvinSchiller]

strange it runs prior bookworm without a fault.

Ok i found why it behaves different on Bookworm.

• Bullseye runs PHP 7.x.
• Bookworm runs PHP 8.x,

There are a few incompatible changes (https://www.php.net/manual/en/migration80.incompatible.php) and this one strikes here

• The behavior of array_key_exists() regarding the type of the key parameter has been made consistent with isset() and normal array access. All key types now use the usual coercions and array/object keys throw a TypeError.

I now checked the error logs (/var/log/lighttpd/error.log) for both versions:
bullseye:

...
2023-12-02 00:07:12: mod_fastcgi.c.487) FastCGI-stderr:PHP Notice:  Undefined variable: fpost in /home/pi/RPi-Jukebox-RFID/htdocs/manageFilesFolders.php on line 283
2023-12-02 00:07:12: mod_fastcgi.c.487) FastCGI-stderr:PHP Notice:  Trying to access array offset on value of type null in /home/pi/RPi-Jukebox-RFID/htdocs/manageFilesFolders.php on line 283
2023-12-02 00:07:12: mod_fastcgi.c.487) FastCGI-stderr:PHP Notice:  Undefined variable: shortcuts in /home/pi/RPi-Jukebox-RFID/htdocs/manageFilesFolders.php on line 283
2023-12-02 00:07:12: mod_fastcgi.c.487) FastCGI-stderr:PHP Warning:  array_key_exists() expects parameter 2 to be array, unknown given in /home/pi/RPi-Jukebox-RFID/htdocs/manageFilesFolders.php on line 283
...

bookworm:

...
2023-12-02 00:29:39: (mod_fastcgi.c.449) FastCGI-stderr:PHP Warning:  Undefined variable $post in /home/pi/RPi-Jukebox-RFID/htdocs/manageFilesFolders.php on line 283
2023-12-02 00:29:39: (mod_fastcgi.c.449) FastCGI-stderr:PHP Warning:  Trying to access array offset on value of type null in /home/pi/RPi-Jukebox-RFID/htdocs/manageFilesFolders.php on line 283
2023-12-02 00:29:39: (mod_fastcgi.c.449) FastCGI-stderr:PHP Warning:  Undefined variable $shortcuts in /home/pi/RPi-Jukebox-RFID/htdocs/manageFilesFolders.php on line 283
2023-12-02 00:29:39: (mod_fastcgi.c.449) FastCGI-stderr:PHP Fatal error:  Uncaught TypeError: array_key_exists(): Argument #2 ($array) must be of type array, null given in /home/pi/RPi-Jukebox-RFID/htdocs/manageFilesFolders.php:283
2023-12-02 00:29:39: (mod_fastcgi.c.449) FastCGI-stderr:Stack trace:
2023-12-02 00:29:39: (mod_fastcgi.c.449) FastCGI-stderr:#0 {main}
2023-12-02 00:29:39: (mod_fastcgi.c.449) FastCGI-stderr:  thrown in /home/pi/RPi-Jukebox-RFID/htdocs/manageFilesFolders.php on line 283
...

So it seems it was also not working on bullseye ( ever working? ), but it was just a silent warning.
Just from reading the code i assume it is intended to preselect a folder based on the selected cardid, but the variables are not set and dont even make sense in this context.

My suggestion is to remove the code snippet.

[s-martin]

Remove it:)