New card actions: play, pause, prev, next, toggle, repeat, shuffle #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pabera
commented
Dec 25, 2023
pabera
commented
- Play, Pause, Previous, Next, Toggle, Repeat, Shuffle
- Fixed some naming conventions and streamlined them with jukebox code
s-martin
approved these changes
Dec 25, 2023
src/webapp/src/components/Cards/controls/actions/synchronisation/index.js
Outdated
Show resolved
Hide resolved
|
In status.md is this note about shuffle:
should we consider the renaming? I think |
pabera
changed the title
AlvinSchiller
approved these changes
Jan 4, 2024
AlvinSchiller
pushed a commit
to AlvinSchiller/RPi-Jukebox-RFID
that referenced
this pull request
Jan 9, 2024
…iczFlor#2179) * Adding additional player controls to assign to cards * streamline some RPC command namings across jukebox and webapp * Fix typos * Fix Repeat toggles * Fix toggle_shuffle * Fix typo in command * Fix another typo * Fix wrong parameter for shuffle * Update German translation for single-repeat * Simplify Shuffle option * Simplify Repeat option * Streamline Player functions with new set_ methods in jukebox * Abstract OptionsSelector * Refactor some code * Fix indentation * Rename set_ methods * Undo some doc changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.