Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBFS without ext2fs attributes support #188

Closed

Conversation

Karlson2k
Copy link
Contributor

Discovered when built on Solaris.

The suggested fix is designed to be minimally intrusive.

Alternatively two implementation could be used: one with attributes support (current) and single print of static line if attributes are not supported.

@Karlson2k
Copy link
Contributor Author

Function chattr_get_as_str is declared in src/filemanager/cmd.h as

#ifdef ENABLE_EXT2FS_ATTR
/* chattr.c */
void chattr_cmd (WPanel * panel);
const char *chattr_get_as_str (unsigned long attr);
#endif

@aborodin aborodin closed this in cfe9ae8 May 21, 2023
@Karlson2k
Copy link
Contributor Author

I've tested the git master. Now dist could be made (tested on Debian Sid) and then mc could be built on Solaris.

However, there are a few compiler warnings, including the warning introduced by this patch:

info.c: In function ‘info_show_info’:
info.c:264:27: warning: unused variable ‘attr’ [-Wunused-variable]
  264 |             unsigned long attr;
      |                           ^~~~

The PR #189 could fix this warning as well.

@Karlson2k Karlson2k deleted the ext2fs_attr_build branch May 22, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant