New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added term windows and multiscreen support to keyboard lib #1539
Conversation
Sounds great! Will give it a spin in a bit. Thanks again. |
Since I'm already working on it, I found a part in event.lua that I don't understand:
Why is the default deadline 0 if you haven't got a filter? |
3c41568
to
6867824
Compare
I updated all programs that are included in OpenOS and added wide character support to edit.lua. |
Just to let you know, haven't forgotten about this, just haven't come around to test it yet, sorry! |
…ing though) Also added wide character support to edit.lua
6867824
to
29c49e0
Compare
No problem. I've implemented a small workaround for #1545. |
All right, looks good from what I've tested (just had to fix the workaround). Thanks again! |
@mpmxyz this work is pretty cool. The features you've built here don't conflict with anything I'm doing (phew!) but definitely I'll have to merge some of my code. My concern is that I would struggle to test my merge sufficiently; you know your code intent better than I would. We should work together on this. Could I merge this with one of my branches and then PR to your repo and then you retest your features? |
That would be okay. I'd just have to improve my "git fu". ;-) |
I've been busy for some time. But initial tests look good. I also found out that I forgot to upload a file to try my example program.
|
@mpmxyz I'd like to alter term a bit - dialog at length in this github comment section might get clunky, and your github email isn't real. Can you join #oc so we can chat? |
I'm on #oc now. |
A crude but working test program:
wget 'https://raw.githubusercontent.com/mpmxyz/ocprograms/dev/home/bin/split.lua'
Some programs have to be modified to support term windows properly. (e.g. to use term.getGlobalArea instead of gpu.getResolution)
I'd do that in a next step.
You can change the focus between term windows by using Ctrl [+ Shift] + Tab
Screenshots of the change:
https://raw.githubusercontent.com/mpmxyz/ocprograms/dev/pics/multiscreen1.png
https://raw.githubusercontent.com/mpmxyz/ocprograms/dev/pics/multiscreen2.png
API changes