Powers of two #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurii-litvinov
approved these changes
Feb 15, 2021
Comment on lines
+5
to
+6
| if n < 0 || m < 0 then None else | ||
| let two = BigInteger.One + BigInteger.One |
There was a problem hiding this comment.
Я даже немного удивлён, что это компилится, хотя если так подумать, в этом есть смысл. Всё же мне больше нравится наличие отступа после else (а лучше и else на отдельной строчке).
| open System | ||
|
|
||
| let powersOfTwo n m = | ||
| if n < 0 || m < 0 then None else |
There was a problem hiding this comment.
Я бы сказал, что тут лучше исключение бросать. Вызывающий сам вполне может проверить параметры, и если он налажал, пусть исключение ловит. Иначе неудобно каждый раз после вызова на Some/None проверять. Хотя исключения не очень в функциональном стиле, так что идеологически Ваше решение правильнее
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.