Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code #2

Closed
Miista opened this issue Jan 11, 2024 · 2 comments · Fixed by #5
Closed

Fix code #2

Miista opened this issue Jan 11, 2024 · 2 comments · Fixed by #5
Assignees
@Miista
Labels
bug Something isn't working
Milestone
v2.0

Comments

@Miista
Copy link
Owner

Miista commented Jan 11, 2024

It is currently not possible to shim anything!
@Miista Miista self-assigned this Jan 11, 2024
@Miista
Copy link
Owner Author

Miista commented Jan 11, 2024 •
edited
Loading

The last good commit seems to be 55fa71c. At least here I can shim something.

It seems that in later commits (closer to the tip of master) calls to get the shim and its replacement method has been left out.

Miista pushed a commit that referenced this issue Jan 11, 2024
@sguldmund
#2 Make shims work again (with the exception of constructors)
5a8ffab
Miista pushed a commit that referenced this issue Jan 11, 2024
@sguldmund
#2 Shimming instance methods for value types
f90be12
Miista pushed a commit that referenced this issue Jan 11, 2024
@sguldmund
#2 Shimming instance methods work
25e4eae
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Constructor shimming works again
8716736
@Miista
Copy link
Owner Author

Miista commented Jan 12, 2024 •
edited
Loading

All code should be fixed now. I got all shims to work again.

Now it's time for adding tests. This should cover #4

@Miista Miista added the bug Something isn't working label Jan 12, 2024
@Miista Miista linked a pull request Jan 12, 2024 that will close this issue
2 fix code #5
Merged
@Miista Miista mentioned this issue Jan 12, 2024
Merged
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Use var everywhere
bd401d2
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Use built-in reference style
83d4960
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Remove unused using statements
d1049be
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Use same brace style everywhere
7575f83
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Remove warnings about "possible multiple enumeration"
241a2e3
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Fix most possible NullReferenceExceptions
a504adb
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Rename members
a1f4793
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 More cleaning
a7edf00
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Extract forwarding logic to separate method
be98705
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Silence a few more warnings
e614fd9
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Silence warnings
1241b05
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Use base type where possible
61547f5
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Rename DevirtualizeMethod => DeVirtualizeMethod
52b0447
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Expand on checks in StubHelper.IsIntrinsic
6122ffc 
It may not be prettier but it may be more readable.
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Add tests verifying that we can rewrite try-catch blocks as implem…
3f2e578 
…ented in tonerdo/pose#42
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Add support for net48
16e9c60 
Fixes tonerdo/pose#74
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 It seems that it was already supported
c900a33 
Related: tonerdo/pose#74
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Improve error messages when throwing InvalidShimSignatureException
264086b 
Fixes tonerdo/pose#75
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Add preprocessor directives to Sandbox
7cba5e4 
This enables us to verify support for different target frameworks by running the sandbox.
Miista pushed a commit that referenced this issue Jan 12, 2024
@sguldmund
#2 Fix support for net4.8
86eed30
This was referenced Jan 13, 2024
Open
Open
Open
@Miista Miista added this to the v2.0 milestone Jan 17, 2024
@Miista Miista closed this as completed in #5 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Miista Miista

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

2 fix code Miista/pose
1 participant
@Miista