ShimHelper.ValidateReplacementMethodSignature has ambiguous and vague output that does not help with debugging #75
Comments
This was referenced Jan 24, 2024
Miista
added a commit
to Miista/pose
that referenced
this issue
Jan 25, 2024
Release v2.0 to NuGet Version 2.0 supports the following targets: * .NET Standard 2.0 * .NET Core 2.0 * .NET Core 3.0 * .NET Framework 4.8 * .NET 7 * .NET 8 Version 2.0 fixes the following issues: * tonerdo/pose#17 * tonerdo/pose#37 * tonerdo/pose#38 * tonerdo/pose#41 * tonerdo/pose#47 * tonerdo/pose#49 * tonerdo/pose#60 * tonerdo/pose#67 * tonerdo/pose#68 * tonerdo/pose#70 * tonerdo/pose#71 * tonerdo/pose#72 * tonerdo/pose#75 * tonerdo/pose#79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Why don't any of the error messages tell me the types they are talking about?
Every single error message in this library should be telling me exactly what's wrong ; It has the data. It just doesn't use it or give it to the user when it explodes for random, often unknown and hard to debug reasons.
ShimHelper.ValidateReplacementMethodSignature() is telling me it has mismatched return types; No idea how or why, because the error output does not tell me. It could, Its literally looking at the type data and it could tell me this easily. But it doesn't, and that's a HUGE bug.
Simply replacing the line on https://github.com/tonerdo/pose/blob/master/src/Pose/Helpers/ShimHelper.cs#L74 with one that includes the type fullnames would be best.
The text was updated successfully, but these errors were encountered: