Update NavBarContainer.js #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for hiding navbar per route Style improvements
|
is the extra indentation on the if statements on purpose? |
|
Nope. let me fix that. |
fixed indent
|
I wish atom had a better way of switching indentation methods per file. Currently it's global, and i use tabs. I try to remedy all these misindentations manually, but this slipped through. sry :( |
| if (this.props.currentRoute.trans) { | ||
| trans = {backgroundColor: 'transparent'}; | ||
| } | ||
| else { |
There was a problem hiding this comment.
This should probably be consistent with the One True Brace in the rest of the code.
|
Mikael, this has been fixed. Let me know if something else pops up. |
MikaelCarpenter
added a commit
that referenced
this pull request
Nov 17, 2015
Update NavBarContainer.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for hiding navbar per route
Style improvements