Feature: BigNumber.sum() #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class method that returns a new BigNumber whose value is the sum of the arguments.
|
Adding tests / minified build shortly... |
|
Alright, should be good to go 👍 |
|
I will consider it, though it is going to be another month or so before I am able to look closely at this library again. One issue is that I am committed to keeping this library compatible with JavaScript engines that only implement ECMAScript 3, so |
|
Cool, I'll make those changes now. |
|
@MikeMcl looks good to you? |
|
Sorry, but it's going to be a month before I can look at this properly and make a decision on it. |
|
I changed my mind on this. I think it's a worthwhile addition. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class method that returns a BigNumber sum of the passed arguments.
Closes #187