Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slang] Fix bug with SignalEventControl iff clause emitting. #1019

Conversation

likeamahoney
Copy link
Contributor

There is copypasta bug with SignalEventControl iffCondition emitting during it's AST constructing. Right hand of iff was constructed from left hand part.

And I also added support for iffCondition serializing.

Add support for iffConfition serialize.
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.23%. Comparing base (04dedf0) to head (38fe37e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1019   +/-   ##
=======================================
  Coverage   94.22%   94.23%           
=======================================
  Files         191      191           
  Lines       47552    47554    +2     
=======================================
+ Hits        44807    44812    +5     
+ Misses       2745     2742    -3     
Files Coverage Δ
source/ast/TimingControl.cpp 90.21% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04dedf0...38fe37e. Read the comment docs.

@MikePopoloski
Copy link
Owner

Nice, thanks for fixing.

@MikePopoloski MikePopoloski merged commit 2d42130 into MikePopoloski:master Jun 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants