Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-31: Adding spy and mock on scenes. #53

Merged
merged 5 commits into from
May 8, 2021
Merged

GD-31: Adding spy and mock on scenes. #53

merged 5 commits into from
May 8, 2021

Conversation

MikeSchulze
Copy link
Owner

  • added example MenuDemo2D

@MikeSchulze MikeSchulze self-assigned this Apr 17, 2021
@MikeSchulze MikeSchulze added the enhancement New feature or request label Apr 17, 2021
@MikeSchulze MikeSchulze added this to the beta v0.9.3 milestone Apr 17, 2021
@MikeSchulze MikeSchulze linked an issue Apr 17, 2021 that may be closed by this pull request
GD-31: Add support to mock and spy on Scenes #31
Closed
@MikeSchulze MikeSchulze changed the title GD-31: Prepared an example with multiple scenes as test environent to implement spy/mock on scenes. GD-31: Adding spy/mock on scenes. Apr 20, 2021
@MikeSchulze MikeSchulze changed the title GD-31: Adding spy/mock on scenes. GD-31: Adding spy and mock on scenes. Apr 20, 2021
@MikeSchulze
Copy link
Owner Author

MikeSchulze commented Apr 25, 2021 •
edited
Loading

Hi @afonsolage @clemens-tolboom the scene mock/spy is mostly done ;)
But to finallize i have to fix runtime errors on GdUnitSceneRunnerTest.gd
It shows some errors related to yielding stuff, but i have current no idea what goes wrong here.
When i execute each test as single no errors occurs but when i run the complete testsuite than this strange errors pops up.

It would be nice if you could check out this branch and play around with it to give me feedback.
Thanks

@clemens-tolboom
Copy link
Contributor

@MikeSchulze I'm not sure I know what a Spy is :-p ... I hope to (re)start my project using this PR soon :-/

@MikeSchulze
Copy link
Owner Author

@MikeSchulze I'm not sure I know what a Spy is :-p ... I hope to (re)start my project using this PR soon :-/

have a look here https://github.com/MikeSchulze/gdUnit3/wiki/Spy#definition
The main difference is that you work on a full initialized object the real implementation is called.

@MikeSchulze MikeSchulze force-pushed the GD-31 branch 2 times, most recently from d76f525 to e886535 Compare May 3, 2021 07:55
@MikeSchulze
GD-31: Mocker and Spy now handled correct 'virtual' functions
8b5b00f 
- mock and spy tracks now all virtual functions
  virtual functions are special, it called by engine over mulit callback
  mock and spy now only counts the interaction and DONT call the real implementation
@MikeSchulze
GD-31: Rework on Spy and simplify it
b271b4b 
- removed the function delagator based on problems when spying on a scene
  the delegator was parentness and add_child was not correct working
@MikeSchulze MikeSchulze force-pushed the GD-31 branch 2 times, most recently from db0713f to 194ea48 Compare May 8, 2021 09:48
@MikeSchulze MikeSchulze merged commit a77db1d into master May 8, 2021
@MikeSchulze MikeSchulze deleted the GD-31 branch May 8, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MikeSchulze MikeSchulze

Labels
enhancement New feature or request
Projects
None yet
Milestone
beta v0.9.3
Development

Successfully merging this pull request may close these issues.

GD-31: Add support to mock and spy on Scenes
2 participants
@MikeSchulze @clemens-tolboom