More pylint fixes

[marksmayo]

Including some newly introduced ones when I rebased

[Miksus]

Thanks! I'll try to check and merge before the end of the week. Sorry for the delay.

[Miksus]

Just some (perhaps opinionated) suggestions to leave the "..." in some code snippets in the documentation to indicate a placeholder and there should be more code in practice.

For example:

def do_things():
    "This does things"
    ...

Vs:

def do_things():
    "This does things"

[Miksus]

Sorry it took almost a month to review (had a bad week, a busy week and a small side project). I think all of those changes are appropriate but I think some of those placehoder ... could be left in the snippets in the docs.

That contribution.md is also a nice addition. Perhaps will motivate others to do an excellent work for the library just as you have done :) Though I would emphasise your fixes role more as you have significantly cleaned up the code base.

[codecov-commenter]

Codecov Report

Base: 94.88% // Head: 94.90% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (49528b0) compared to base (7765b53).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   94.88%   94.90%   +0.02%     
==========================================
  Files          80       80              
  Lines        4454     4454              
==========================================
+ Hits         4226     4227       +1     
+ Misses        228      227       -1     

Impacted Files	Coverage Δ
rocketry/parse/_setup_cond_parsers.py	100.00% <ø> (ø)
rocketry/args/builtin.py	98.50% <100.00%> (ø)
rocketry/conditions/api.py	98.36% <100.00%> (ø)
rocketry/conditions/task/task.py	93.87% <100.00%> (ø)
rocketry/core/schedule.py	93.50% <100.00%> (+0.36%)	⬆️
rocketry/core/task.py	91.41% <100.00%> (ø)
rocketry/log/log_record.py	100.00% <100.00%> (ø)
rocketry/session.py	95.72% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[marksmayo]

Think I've made them all

[marksmayo]

Still says changes requested but I think I've resolved all? Just pulling in latest from your repo to see if I've missed any new ones

[Miksus]

Yep, looks good. Thanks again for the fixes and sorry for the immense delay. I now booked an hour every week to go through PRs and issues so hopefully, there won't be the same delay anymore.

[marksmayo]

All good. I'm still learning so in no hurry.