Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add new conditions to condition API #57

Merged
merged 19 commits into from
Jul 23, 2022
Merged

ENH: Add new conditions to condition API #57

merged 19 commits into from
Jul 23, 2022

Conversation

Miksus
Copy link
Owner

@Miksus Miksus commented Jul 17, 2022

This update also adds new time component: TimeSpanDelta and fixes task crash logging.

This time component represents time delta that has start and end ie.
20 seconds ago to 10 seconds ago.
@Miksus Miksus added the built-in Relates to the built-in tasks, conditions etc. label Jul 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2022

Codecov Report

Merging #57 (a2f001d) into master (91790ee) will increase coverage by 0.14%.
The diff coverage is 96.09%.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   90.56%   90.71%   +0.14%     
==========================================
  Files          86       87       +1     
  Lines        3934     4028      +94     
==========================================
+ Hits         3563     3654      +91     
- Misses        371      374       +3     
Impacted Files Coverage Δ
rocketry/conds/__init__.py 100.00% <ø> (ø)
rocketry/core/task.py 92.61% <91.66%> (+0.51%) ⬆️
rocketry/conditions/api.py 96.69% <95.71%> (-3.31%) ⬇️
rocketry/time/delta.py 97.05% <97.05%> (ø)
rocketry/conditions/task/task.py 91.39% <100.00%> (-0.74%) ⬇️
rocketry/time/__init__.py 100.00% <100.00%> (ø)
rocketry/core/schedule.py 90.00% <0.00%> (+0.03%) ⬆️
rocketry/session.py 91.40% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91790ee...a2f001d. Read the comment docs.

@Miksus Miksus merged commit 73f8b47 into master Jul 23, 2022
@Miksus Miksus deleted the dev/add_cond_api branch July 23, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
built-in Relates to the built-in tasks, conditions etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants