-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add async tasks #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was due to flag was inspected before hibernate causing a metatask that restarts to run possibly twice.
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 90.41% 90.56% +0.15%
==========================================
Files 86 86
Lines 3892 3934 +42
==========================================
+ Hits 3519 3563 +44
+ Misses 373 371 -2
Continue to review full report at Codecov.
|
Looking forward to this feature! |
Otherwise the termination will not be recorded.
This PR also fixes numeric timeout, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
built-in
Relates to the built-in tasks, conditions etc.
core
Relates to the core functionalities (ie. base classes)
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds async support (#28) for the main scheduler but also adds support for parallelizing tasks as async.
For example:
Some notes:
async def ...
is used with execution asmain
, the scheduler won't continue until the task is completedasync def ...
but justdef ...
, the task cannot be parallelized