Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small update on examples.md for 1-based indexing #302

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

liuyxpp
Copy link
Contributor

@liuyxpp liuyxpp commented Apr 10, 2024

Since we are in Julia not in Python, the indices of x3 and x0 should really be x4 and x1 to be consistent with the code to avoid any confusion.

Since we are in Julia not in Python, the indices of `x3` and `x0` should really be `x4` and `x1` to be consistent with the code to avoid any confusion.
Copy link
Contributor

Benchmark Results

master 7a079a6... master/7a079a6926a990...
search/multithreading 25.8 ± 0.8 s 26.1 ± 1.1 s 0.987
search/serial 33.6 ± 0.081 s 33 ± 0.15 s 1.02
utils/best_of_sample 0.972 ± 0.3 μs 0.922 ± 0.35 μs 1.05
utils/check_constraints_x10 11.4 ± 3 μs 11.5 ± 2.9 μs 0.996
utils/compute_complexity_x10/Float64 2.21 ± 0.11 μs 2.19 ± 0.11 μs 1.01
utils/compute_complexity_x10/Int64 2.18 ± 0.11 μs 2.18 ± 0.11 μs 1
utils/compute_complexity_x10/nothing 1.44 ± 0.091 μs 1.44 ± 0.1 μs 1
utils/optimize_constants_x10 30.8 ± 6.6 ms 30.9 ± 6.9 ms 0.996
time_to_load 0.915 ± 0.0089 s 0.928 ± 0.013 s 0.987

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer
Copy link
Owner

Good point! Thanks

@MilesCranmer MilesCranmer merged commit a8360fb into MilesCranmer:master Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants