Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace tippy with floating ui in plugin block #1356

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

Saul-Mirone
Copy link
Member

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Replace tippy with floating ui in plugin block

How did you test this change?

CI and manually

Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 7:32am

Copy link

nx-cloud bot commented Jun 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c09c3c8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

Copy link

cypress bot commented Jun 2, 2024

Passing run #858 ↗︎

0 83 0 0 Flakiness 0

Details:

Merge c09c3c8 into 84c24c2...
Project: Default Project Commit: e9b2d67222 ℹ️
Status: Passed Duration: 01:54 💡
Started: Jun 2, 2024 7:36 AM Ended: Jun 2, 2024 7:38 AM

Review all test suite changes for PR #1356 ↗︎

@Saul-Mirone Saul-Mirone merged commit 29840bd into main Jun 2, 2024
14 checks passed
@Saul-Mirone Saul-Mirone deleted the use-floating-ui-in-block branch June 2, 2024 07:56
Copy link

cypress bot commented Jun 2, 2024

Passing run #859 ↗︎

0 83 0 0 Flakiness 0

Details:

feat: replace tippy with floating ui in plugin block (#1356)
Project: Default Project Commit: 29840bd597
Status: Passed Duration: 01:41 💡
Started: Jun 2, 2024 7:59 AM Ended: Jun 2, 2024 8:00 AM

Review all test suite changes for PR #1356 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant