Speedup pipelines #1168
Merged
Speedup pipelines #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symbiogenesis
force-pushed
the
speedup-pipelines
branch
from
7cc0af1
to
6d968fe
Compare
symbiogenesis
force-pushed
the
speedup-pipelines
branch
from
6d968fe
to
f134e22
Compare
symbiogenesis
force-pushed
the
speedup-pipelines
branch
6 times, most recently
from
35b3c8c
to
2a46908
Compare
symbiogenesis
force-pushed
the
speedup-pipelines
branch
2 times, most recently
from
1c0010f
to
0b57e90
Compare
symbiogenesis
force-pushed
the
speedup-pipelines
branch
2 times, most recently
from
62b7977
to
4f98185
Compare
symbiogenesis
force-pushed
the
speedup-pipelines
branch
from
4f98185
to
d80f38a
Compare
|
@Mimetis This should fix the pipelines and also improve them a bunch. And it closes two of the issues I just opened. Those have some explanation of the justifications. The cache step may need some tweaking because I'm not sure if it is working. |
symbiogenesis
force-pushed
the
speedup-pipelines
branch
from
9682ee9
to
ff39ae8
Compare
symbiogenesis
force-pushed
the
speedup-pipelines
branch
2 times, most recently
from
a68e891
to
8926277
Compare
symbiogenesis
force-pushed
the
speedup-pipelines
branch
from
8926277
to
48db446
Compare
|
@Mimetis this should make the pipelines green. I just resolved the conflicts from today. |
|
@symbiogenesis nice, I'll look this week end for sure |
symbiogenesis
force-pushed
the
speedup-pipelines
branch
from
b4cb0fe
to
bd5e838
Compare
|
Hey @symbiogenesis , I'm struggling a little bit with the tests pipelines since this PR Seems the tests are not run when targeting .net core 3.1 Any idea ? |
|
hum I don't know what I've done, but it's working now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may go some ways towards speeding up the pipelines
I think it will save a couple minutes per pipeline. Refactoring the tests, as described in #1162 would help more substantially.
The cache step won't save any time on the first run, but subsequent runs will benefit.
Generating lockfiles was necessary in order to create a perfect cache key
Fixes #1167 and #1165