Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIP] kimchi #9

Merged
merged 5 commits into from
Mar 28, 2023
Merged

[MIP] kimchi #9

merged 5 commits into from
Mar 28, 2023

Conversation

mimoo
Copy link
Contributor

@mimoo mimoo commented Mar 1, 2023

The MIP introducing Kimchi

@yourbuddyconner
Copy link

This pull request has been mentioned on MinaResearch. There might be relevant details there:

https://forums.minaprotocol.com/t/kimchi-mip-a-proposed-upgrade-to-minas-proof-system/6004/1

imikushin
imikushin reviewed Mar 18, 2023
View reviewed changes
mip-kimchi.md Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in the MIPS folder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this :)

@kantp
Copy link
Member

kantp commented Mar 22, 2023

Thanks @mimoo, this looks great!

One nitpick: I noticed this MIP does not have a Test Cases section, which the README.md requires.

Can we add a section, or some comments here, on what kind of testing we're planning for including Kimchi in Mina?

@Cris-F Cris-F merged commit 34592a7 into MinaProtocol:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imikushin imikushin imikushin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mimoo @yourbuddyconner @kantp @imikushin @Cris-F