Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Fix transition router switch logic #1473

Open
nholland94 opened this issue Jan 18, 2019 · 5 comments
Open

Refactor: Fix transition router switch logic #1473

nholland94 opened this issue Jan 18, 2019 · 5 comments
Assignees
@nholland94 @ghost-not-in-the-shell
Labels
consider-for-Q2 daemon easy refactor technical-debt
Projects
Transition Frontier Controller Protocol Prioritization

Comments

@nholland94
Copy link
Member

nholland94 commented Jan 18, 2019 •
edited by imeckler
Loading

Existing transition router switch logic is fragile. @nholland94 would like to fix it up. In particular

  1. It's not clear that pipes are always closed in the right way.
  2. The rules for switching between participation + bootstrap are not obviously correct.
@nholland94 nholland94 created this issue from a note in Transition Frontier Controller (To do) Jan 18, 2019
@nholland94 nholland94 self-assigned this Jan 18, 2019
@nholland94 nholland94 moved this from To do to In progress in Transition Frontier Controller Jan 18, 2019
@nholland94 nholland94 mentioned this issue Jan 18, 2019
Merged
bkase added a commit that referenced this issue Jan 18, 2019
@bkase
Failwith on bootstrap clean (#1475)
6bc05d1 
Prevent an infinite loop by disabling this function for now

This allows us to continue properly testing proof of stake in parallel to completing this issue #1473
@jkrauska jkrauska added this to To discuss in Protocol Prioritization May 16, 2019
@jkrauska jkrauska changed the title Fix transition router switch logic VAGUE: Fix transition router switch logic May 16, 2019
@imeckler imeckler changed the title VAGUE: Fix transition router switch logic Refactor: Fix transition router switch logic May 16, 2019
@imeckler imeckler moved this from Discuss to Next Week in Protocol Prioritization May 16, 2019
@jkrauska jkrauska moved this from Next 14 Days to Next 7 Days in Protocol Prioritization May 24, 2019
@imeckler
Copy link
Member

@nholland94 if @ghost-not-in-the-shell 's recent changes don't address this issue as far as you're concerned, could you make another more specific issue?

Transition Frontier Controller automation moved this from In progress to Done May 31, 2019
Protocol Prioritization automation moved this from Next 7 Days to Done May 31, 2019
@imeckler imeckler reopened this May 31, 2019
Transition Frontier Controller automation moved this from Done to In progress May 31, 2019
@imeckler imeckler moved this from Done to Next 7 Days in Protocol Prioritization May 31, 2019
@nholland94
Copy link
Member Author

@imeckler Jiawei ended up just trying to patch the logic as it was rather than doing a full refactor. The necessary refactor is still an open issue.

@imeckler imeckler moved this from Next 7 Days to Done in Protocol Prioritization Jun 7, 2019
@nholland94
Copy link
Member Author

This work will soon be required due to changes in the transition frontier initialization logic that need some new state management logic in the transition router.

@imeckler imeckler closed this as completed Nov 6, 2020
Transition Frontier Controller automation moved this from In progress to Done Nov 6, 2020
@nholland94
Copy link
Member Author

@imeckler we are still encountering bugs due to this work not being done. Recently @mrmr1993 encountered yet another closed pipe issue. I don't think we should close this issue.

@nholland94 nholland94 reopened this Nov 9, 2020
Transition Frontier Controller automation moved this from Done to In progress Nov 9, 2020
@georgeee georgeee mentioned this issue Jan 9, 2024
Merged
7 tasks
@emberian
Copy link
Contributor

emberian commented Feb 2, 2024

Maybe we can take some inspiration from how openmina architects their stuff around reducers to try and clean this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nholland94 nholland94

@ghost-not-in-the-shell ghost-not-in-the-shell

Labels
consider-for-Q2 daemon easy refactor technical-debt
Projects
No open projects
Protocol Prioritization
  
Done
Transition Frontier Controller
  
In progress
Milestone
No milestone
Development

No branches or pull requests
5 participants
@emberian @imeckler @nholland94 @ghost-not-in-the-shell @aneesharaines