Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rampup port: Fix genesis ledger directory growing in size #14819

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Jan 9, 2024

Port of PR Fix genesis ledger directory growing in size #1473 that is in berkeley, but evaded rampup sadly.

Explain how you tested your changes:

  • Not tested

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee requested a review from a team as a code owner January 9, 2024 18:18
@georgeee
Copy link
Member Author

georgeee commented Jan 9, 2024

!ci-build-me

Copy link
Contributor

@emberian emberian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping this port, but gonna make a quick follow up PR to use File_system.create_dir

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar deepthiskumar merged commit 05f42b6 into rampup Jan 9, 2024
36 checks passed
@deepthiskumar deepthiskumar deleted the georgeee/fix-genesis-ledger-dir-to-rampup branch January 9, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants