Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uint64 comparing in JS #10284

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Fix uint64 comparing in JS #10284

merged 3 commits into from
Feb 25, 2022

Conversation

mitschabaude
Copy link
Member

@mitschabaude mitschabaude commented Feb 24, 2022

Explain your changes:

Explain how you tested your changes:

  • Verified manually that this fixes uint64 comparison

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@mitschabaude mitschabaude requested a review from a team as a code owner February 24, 2022 16:39
@mitschabaude mitschabaude mentioned this pull request Feb 24, 2022
6 tasks
@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Feb 24, 2022
@mrmr1993 mrmr1993 merged commit 15a832d into develop Feb 25, 2022
@mrmr1993 mrmr1993 deleted the feature/fix-integer-stubs-js branch February 25, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants