We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The way UInt64s are handled does not properly install the written comparison function.
I believe this is because uint64 values are actually represented as int64 so the setting of custom functions here does nothing:
caml_custom_ops["integers:uint64"] = { serialize: caml_int64_marshal , deserialize: caml_int64_unmarshal , hash: caml_int64_hash , compare: integers_uint64_compare };
As a result, the compare function for uint64s is the signed compare, and thus does not work correctly.
The text was updated successfully, but these errors were encountered:
I agree with the analysis.
Sorry, something went wrong.
We have a fix for this in MinaProtocol/mina#10284 (thanks @mitschabaude!). I'll try to update here and push to opam sometime over the weekend.
No branches or pull requests
The way UInt64s are handled does not properly install the written comparison function.
I believe this is because uint64 values are actually represented as int64 so the setting of custom functions here does nothing:
As a result, the compare function for uint64s is the signed compare, and thus does not work correctly.
The text was updated successfully, but these errors were encountered: