Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit dependencies in transition frontier #10466

Merged

Conversation

ylecornec
Copy link
Collaborator

@ylecornec ylecornec commented Mar 11, 2022

This PR sets (implicit_transitive_deps false) in src/lib/transition_frontier/dune-project, adds the necessary explicit dependencies to the dune files and remove some unnecessary ones.

Explain how you tested your changes:

  • dune build src/lib/transition_frontier
  • make build
  • The CI.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@ylecornec ylecornec added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Mar 11, 2022
@ylecornec ylecornec marked this pull request as ready for review March 11, 2022 12:31
@ylecornec ylecornec requested a review from a team as a code owner March 11, 2022 12:31
@mrmr1993 mrmr1993 merged commit dc7b79d into develop Mar 11, 2022
@mrmr1993 mrmr1993 deleted the ylecornec/explicit_dependencies_in_transition_frontier branch March 11, 2022 14:46
@robinbb robinbb added the Tweag label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants