Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit dependencies in dune files #10653

Merged
merged 10 commits into from
Apr 11, 2022

Conversation

ylecornec
Copy link
Collaborator

@ylecornec ylecornec commented Mar 29, 2022

This PR propagates the changes about explicit dependencies made in the develop branch to compatible(the OCaml direct dependencies are now written explicitly in dune files and some unnecessary ones were removed), and takes into account the few different libraries between the branches (the biggest one being the use of the kimchi backend).

These changes to develop were made in the following PRs: #10331 (the main one), #10439, #10436, #10444, #10455 and #10466.

Checklist:

@ylecornec ylecornec changed the base branch from develop to compatible March 29, 2022 16:13
@ylecornec ylecornec force-pushed the ylecornec/explicit_dependencies branch from 8eb7299 to 9a913db Compare March 29, 2022 16:25
@ylecornec ylecornec added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Mar 29, 2022
@ylecornec ylecornec force-pushed the ylecornec/explicit_dependencies branch from 9a913db to 729d9ac Compare March 29, 2022 17:06
@ylecornec ylecornec force-pushed the ylecornec/explicit_dependencies branch from 729d9ac to 4ef672d Compare March 30, 2022 06:14
@ylecornec ylecornec marked this pull request as ready for review March 30, 2022 08:16
@ylecornec ylecornec requested review from a team as code owners March 30, 2022 08:16
@ylecornec ylecornec merged commit 294a277 into compatible Apr 11, 2022
@ylecornec ylecornec deleted the ylecornec/explicit_dependencies branch April 11, 2022 11:11
@robinbb robinbb added the Tweag label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants