check opam switch - compatible #11569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylecornec
added
Tweag
ci-build-me
This was referenced Jul 26, 2022
ylecornec
force-pushed
the
ylecornec/check_opam_switch-compatible
branch
from
3f31097
to
e71ce26
Compare
mimoo
reviewed
Jul 27, 2022
mimoo
reviewed
Jul 27, 2022
mrmr1993
approved these changes
Aug 8, 2022
| @@ -51,6 +51,7 @@ inputs: pkgs: { | |||
| buildPhase = "make check-format"; | |||
| installPhase = "touch $out"; | |||
| meta.checkDescription = "that OCaml code is formatted properly"; | |||
| DISABLE_CHECK_OPAM_SWITCH = "true"; | |||
There was a problem hiding this comment.
I'm not entirely convinced that we should skip the check here: using the wrong opam.export may give us different formatting, depending on the version of ocamlformat.
There was a problem hiding this comment.
(btw I think the ocamlformat version should be enforced with an .ocamlformat file)
There was a problem hiding this comment.
For this check, the environment is managed via nix and not opam, so the check_opam_switch tool does not work in this case.
It should not be needed however as nix directly reads the opam.export file to setup the environment.
…_opam_switch-compatible
lk86
approved these changes
Aug 25, 2022
…_opam_switch-compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11570 for the develop version of this PR.
This PR enables the check_opam_switch tool, that provides two binaries to check that the current opam switch contains the packages from the
opam.exportfile (at the same version):check_opam_switchsimply does the check,dune_wrapperdoes the check before invoking dune (so it is possible to keep using dune as usual (with an alias) but notice early when the switch needs to be updated).Other changes:
The
opam.exportfile was moved to the root of the dune project, as expected bydune_wrapperby default (this way it is simpler to usedune_wrapperin multiple projects).The check was added to the
ocaml_checksrule of the makefile (to notice early that the switch needs to be updated when compiling the project from the makefile).See issue #10982 and PR #11450 for context.