Make the ordering of accounts in the result of a zkApp txn application explicit #13435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
The current version implicitly depends on the ordering provided by the
Hashtbl
implementation in thebase
library, which is not explicit. This order my change either by changes to theHashtbl
implementation, or because of changes to this function, so it is important to make the ordering explicit and stable.IMPORTANT this change introduces an incompatibility with the current
berkeleynet
, because the order of these accounts in the result will change, affecting the hashing of the scan state.Explain how you tested your changes:
Not tested yet
Checklist: