Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ordering of accounts in the result of a zkApp txn application explicit #13435

Merged

Conversation

tizoc
Copy link
Member

@tizoc tizoc commented Jun 20, 2023

Explain your changes:

The current version implicitly depends on the ordering provided by the Hashtbl implementation in the base library, which is not explicit. This order my change either by changes to the Hashtbl implementation, or because of changes to this function, so it is important to make the ordering explicit and stable.

IMPORTANT this change introduces an incompatibility with the current berkeleynet, because the order of these accounts in the result will change, affecting the hashing of the scan state.

Explain how you tested your changes:

Not tested yet

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

…f the accessed accounts list explicit.

The current version implicitly depends on the ordering provided
by the `Hashtbl` implementation in the `base` library, which
is not explicit. This order my change either by changes to the
`Hashtbl` implementation, or because of changes to this function,
so it is important to make the ordering explicit and stable.
@tizoc tizoc requested a review from a team as a code owner June 20, 2023 22:38
@tizoc
Copy link
Member Author

tizoc commented Jun 20, 2023

!ci-build-me

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar deepthiskumar merged commit 60855cf into MinaProtocol:berkeley Jun 21, 2023
@tizoc tizoc deleted the stable-zkapp-account-order branch June 21, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants