Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting zkapp limit in orchestrator #14818

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Jan 9, 2024

Bonus: ability to check that X% of stake were updated.

Explain your changes:

  • Adds a command to Orchestrator to allow setting zkapp limit on nodes in the test environment
  • Adds a command that (combined with existing slots-won command) allows to check that at least X% of stake were affected by the soft limit upgrade

Explain how you tested your changes:

  • Tested on the large cluster:
    • set limit to 23 zkapp txs/min
      {"action":"discovery","params":{"offsetMin":15}}
      {"action":"set-zkapp-soft-limit","params":{"limit":23,"nodes":{"type":"output","step":-1,"name":"participant"}}}
      {"action":"slots-won","params":{"nodes":{"type":"output","step":-1,"name":"participant"}}}
      {"action":"slots-covered-check","params":{"threshold":0.6,"slotsWon":{"type":"output","step":-1,"name":"slotsWon"}}}
      
    • switch on the zkapp transaction sending
    • unset the limit
      {"action":"discovery","params":{"offsetMin":15}}
      {"action":"set-zkapp-soft-limit","params":{"limit":null,"nodes":{"type":"output","step":-1,"name":"participant"}}}
      {"action":"slots-won","params":{"nodes":{"type":"output","step":-1,"name":"participant"}}}
      {"action":"slots-covered-check","params":{"threshold":0.6,"slotsWon":{"type":"output","step":-1,"name":"slotsWon"}}}
      

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee force-pushed the georgeee/update-orchestrator-to-use-soft-limit branch from f817073 to da0d244 Compare January 9, 2024 19:38
@georgeee georgeee requested a review from a team as a code owner January 9, 2024 19:38
@georgeee georgeee force-pushed the georgeee/update-orchestrator-to-use-soft-limit branch from da0d244 to 31a71e5 Compare January 9, 2024 19:39
@georgeee
Copy link
Member Author

georgeee commented Jan 9, 2024

!ci-build-me

@georgeee georgeee force-pushed the georgeee/update-orchestrator-to-use-soft-limit branch from 31a71e5 to 72da728 Compare January 10, 2024 09:41
@georgeee
Copy link
Member Author

!ci-build-me

@georgeee georgeee force-pushed the georgeee/update-orchestrator-to-use-soft-limit branch from d31e566 to 1b6a079 Compare January 10, 2024 16:29
@georgeee
Copy link
Member Author

!ci-build-me

@mrmr1993
Copy link
Member

!approved-for-mainnet

@emberian emberian merged commit 1f58bfb into rampup Jan 10, 2024
37 checks passed
@emberian emberian deleted the georgeee/update-orchestrator-to-use-soft-limit branch January 10, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants