Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verification in dry runs: alternative take #15591

Merged
merged 2 commits into from
May 1, 2024
Merged

Fix verification in dry runs: alternative take #15591

merged 2 commits into from
May 1, 2024

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Apr 30, 2024 •
edited

Fix verification of fork package.

Develop version: #15599

Explain how you tested your changes:

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@georgeee georgeee requested review from a team as code owners April 30, 2024 16:52
@georgeee georgeee mentioned this pull request Apr 30, 2024
Open
@mrmr1993
Copy link
Member

!ci-build-me

@mrmr1993
Copy link
Member

!approved-for-mainnet

@georgeee georgeee force-pushed the georgeee/fix-build-hardfork-package-default-env-vars-alt branch from 29abe07 to 5143f23 Compare April 30, 2024 19:10
dkijania
dkijania approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@dkijania dkijania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will update nightly cron job after this is merged

@deepthiskumar
Copy link
Member

!ci-build-me

@georgeee
Copy link
Member Author

georgeee commented May 1, 2024

Reviewed change by Jiawei, pushed a tiny fixup to simplify the code

@georgeee georgeee force-pushed the georgeee/fix-build-hardfork-package-default-env-vars-alt branch from 4596a8b to 6830481 Compare May 1, 2024 14:54
@ghost-not-in-the-shell
Copy link
Member

!ci-build-me

@georgeee georgeee mentioned this pull request May 1, 2024
Merged
10 tasks
@deepthiskumar deepthiskumar merged commit b903724 into berkeley May 1, 2024
9 of 11 checks passed
@deepthiskumar deepthiskumar deleted the georgeee/fix-build-hardfork-package-default-env-vars-alt branch May 1, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanabriaRusso SanabriaRusso SanabriaRusso approved these changes

@mrmr1993 mrmr1993 mrmr1993 approved these changes

@dkijania dkijania dkijania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@georgeee @mrmr1993 @deepthiskumar @ghost-not-in-the-shell @SanabriaRusso @dkijania