Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Develop] Fix verification in dry runs: alternative take #15599

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented May 1, 2024

Fix verification of fork package.

Berkeley version: #15591

Explain how you tested your changes:

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee requested review from a team as code owners May 1, 2024 21:47
@georgeee
Copy link
Member Author

georgeee commented May 1, 2024

PR also contains upstream merge of berkeley to develop. Only conflict was in MinaArtifact.dhall, due to the fact that hardfork pipeline is not present in develop.

@georgeee
Copy link
Member Author

georgeee commented May 1, 2024

!ci-build-me

@georgeee
Copy link
Member Author

georgeee commented May 2, 2024

!ci-build-me

@ghost-not-in-the-shell ghost-not-in-the-shell merged commit 9f38ff1 into develop May 3, 2024
10 checks passed
@ghost-not-in-the-shell ghost-not-in-the-shell deleted the georgeee/fix-build-hardfork-package-default-env-vars-alt-develop branch May 3, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants