Migrate to Swift 5 🚀 #193
Merged
Migrate to Swift 5 🚀 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p4checo
requested review from
renatorodrigues,
beloso,
portellaa,
diogoeiras,
dbeleza,
ivopintodasilva,
jwelton,
tiagoalexbastos,
andremartingo and
filipe-lemos
- Migrate project to Swift 5.0 (Xcode 10.2) - Update .podspec’s `swift_version` - Update .travis.yml’s `osx_image` to 10.2
Good bye old friend, you have served us well 🙇♂️ - Remove `antitypical/Result` dependency. - Remove Carthage integration. - Make necessary adjustments to use stdlib’s `Result` ✨.
p4checo
force-pushed
the
migrate-to-swift-5
branch
from
f139b23
to
75a6f6f
Compare
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
==========================================
+ Coverage 92.39% 93.01% +0.61%
==========================================
Files 91 91
Lines 2907 3435 +528
==========================================
+ Hits 2686 3195 +509
- Misses 221 240 +19
Continue to review full report at Codecov.
|
Not sure why (probably because of some timing issues), but the coverage for `URLSessionNetworkStack` UT’s dropped a bit after the Swift 5 migration, so I added some missing tests which should also be deterministic.
- Add a Compatibility section, and some missing emojis 🤓
diogoeiras
approved these changes
Apr 29, 2019
jwelton
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Migrate project to Swift 5.0 (Xcode 10.2) 🚀
Update .podspec’s
swift_versionUpdate .travis.yml’s
osx_imageto 10.2Remove
antitypical/ResultRemove Carthage integration.
Make necessary adjustments to use stdlib’s
Result✨.