Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to autodiscover, or explicitly pass application version number #1

Merged
merged 3 commits into from
Apr 26, 2016

Conversation

JoshuaColeman
Copy link

I have been using the NLog.Raygun NuGet package recently and found myself wanting an ability to specify application version in the adapter configuration. I have provided two options:

  • Automatically detect the application version from an executing assembly (command line app, etc), or the first non ASP.Net assembly (web app).
  • Explicitly specify an ApplicationVersion in the NLog configuration.

I updated the README.md and examples.

@JoshuaColeman
Copy link
Author

@dwnz: If a new NuGet package is going to be cut, the references to raygun should be updated.

@dwnz
Copy link

dwnz commented Apr 22, 2016

Hey @JoshuaColeman,

Thanks heaps for submitting this! Looks good.

Just one note - would you mind changing the ?. to old fashioned null checks. We don't publish a nuget package for this as it's owned by someone else, so needs to be as compatible as possible.

Cheers,
Daniel

@JoshuaColeman
Copy link
Author

@dwnz: Heh, I thought about that possibly being an issue after creating the Pull Request. Changes are in.

@dwnz
Copy link

dwnz commented Apr 26, 2016

@JoshuaColeman No worries! One day we'll all be able to use modern language features :)

Thanks heaps for this! Merging in now

@dwnz dwnz merged commit f31ab8d into MindscapeHQ:master Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants