Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracekit bug fix #298

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Tracekit bug fix #298

merged 2 commits into from
Sep 28, 2018

Conversation

BenjaminHarding
Copy link
Contributor

Fixes a bug where our version of tracekit wouldn't go past the computeStackTraceFromStackProp due to it passing back a truthy value.

Copy link
Contributor

@UberMouse UberMouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what this change does. But I assume it's fine

@BenjaminHarding
Copy link
Contributor Author

BenjaminHarding commented Sep 28, 2018

Let me explain then. In tracekit there are a number of different ways to compute the stacktrace depending on the browser/properties on the exception.

All of these computeStackTraceFrom[X] methods are called in order when they continue to return falsely values.

The bug comes from a previous update changing one of the computeStackTrace methods to return a object instead of falsely, thus breaking it.

@BenjaminHarding BenjaminHarding merged commit 26240a9 into master Sep 28, 2018
@BenjaminHarding BenjaminHarding deleted the tracekit-bug-fix branch September 28, 2018 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants