Rework of GDAL-export #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests failed, something about recursion depth. On my system all tests were passed - can somebody help me out? |
Closed
|
I did a rebase so now the code is cleanly separated from other work. |
|
Given @psi29a worked on GDAL stuff I would wait for his comments. This one is not urgent, right? |
|
This one is separated from everything else - unless somebody starts working on GDAL himself, this can wait. |
tcld
force-pushed
the
gdal_chng
branch
2 times, most recently
from
dc465ae
to
c9bcc5c
Compare
|
I like what I see and makes a few things simpler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This originally went into #141 (which happened due to me working on too many things at once). I now separated it to make things easier for everybody.
I decided to make some rather big changes to the way GDAL export is handled: I think the commandline interface is now a little bit easier to use, and the changes to
imex/__init__.pyactually allow the user to make use of every format GDAL can handle while hopefully not making things more complicated than they were before.I based this off of #146 even though it wasn't strictly necessary. I figured that discussing the changes happening here would take longer than merging the other PR anyway.
Here the link to the only commit that is relevant: b8d098f