Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to README and CHANGELOG #196

Merged
merged 2 commits into from
Nov 17, 2015
Merged

Updates to README and CHANGELOG #196

merged 2 commits into from
Nov 17, 2015

Conversation

tcld
Copy link
Contributor

@tcld tcld commented Nov 16, 2015

I only updated what I knew of; might have overlooked some things.
(I also reordered the bullet points in the changelog a bit - changes first, then additions, then removals.)

@ftomassetti
Copy link
Member

The build stalled, restarting it

* Added export support using libgdal
* Force rivers and grayscale_heightmap to PNG to avoid ambiguity of providing a
filename which can introduce input error.
* Force rivers and grayscale_heightmap to PNG to avoid ambiguity of providing a filename which can introduce input error.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rephrase this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. But I didn't come up with this sentence.^^

How about..."force blabla to PNG" only? I am not sure if somebody who reads the changelog needs to know about all the details.
Other suggestions welcome. :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Rivers and grayscale heightmaps are generated as png images" ?

@ftomassetti
Copy link
Member

It looks good to me, just a minor comment added. And finally you had yourself to the contributors after just 68 commits :D

@tcld tcld force-pushed the rel_pol1 branch 2 times, most recently from 9c4867e to 9bb84d6 Compare November 16, 2015 14:57
* Added export support using libgdal
* Force rivers and grayscale_heightmap to PNG to avoid ambiguity of providing a
filename which can introduce input error.
* Rivers and grayscale_heightmaps are generated as PNG images, filenames no longer have to be provided.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@psi29a
Copy link
Member

psi29a commented Nov 17, 2015

Looks good!

psi29a added a commit that referenced this pull request Nov 17, 2015
Updates to README and CHANGELOG
@psi29a psi29a merged commit 5600355 into Mindwerks:master Nov 17, 2015
@tcld tcld deleted the rel_pol1 branch November 17, 2015 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants