-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to README and CHANGELOG #196
Conversation
The build stalled, restarting it |
* Added export support using libgdal | ||
* Force rivers and grayscale_heightmap to PNG to avoid ambiguity of providing a | ||
filename which can introduce input error. | ||
* Force rivers and grayscale_heightmap to PNG to avoid ambiguity of providing a filename which can introduce input error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rephrase this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. But I didn't come up with this sentence.^^
How about..."force blabla to PNG" only? I am not sure if somebody who reads the changelog needs to know about all the details.
Other suggestions welcome. :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Rivers and grayscale heightmaps are generated as png images" ?
It looks good to me, just a minor comment added. And finally you had yourself to the contributors after just 68 commits :D |
9c4867e
to
9bb84d6
Compare
* Added export support using libgdal | ||
* Force rivers and grayscale_heightmap to PNG to avoid ambiguity of providing a | ||
filename which can introduce input error. | ||
* Rivers and grayscale_heightmaps are generated as PNG images, filenames no longer have to be provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
Looks good! |
Updates to README and CHANGELOG
I only updated what I knew of; might have overlooked some things.
(I also reordered the bullet points in the changelog a bit - changes first, then additions, then removals.)