Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing documentation for release v0.19.0 #198

Merged
merged 6 commits into from
Nov 18, 2015
Merged

Conversation

ftomassetti
Copy link
Member

This is to address #193

@@ -324,10 +285,10 @@ If you are using WorldEngine please let us know!
Contributors
============

The merged project is maintained by [Bret Curtis](https://github.com/psi29a) and [Federico Tomassetti](https://github.com/ftomassetti).
The this project is maintained by [Bret Curtis](https://github.com/psi29a) and [Federico Tomassetti](https://github.com/ftomassetti).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a superfluous word here (the/this).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, solved

@tcld
Copy link
Contributor

tcld commented Nov 16, 2015

I may have added a lot of comments. Some of the parameters really don't seem clear to me, although most of them certainly could be.

Is the explanation of parameters somehow auto-generated?

@ftomassetti
Copy link
Member Author

It is good to have many comments here. It is true that much stuff is rather obscure. I would try to make definitions more clear. In the long run it would be amazing to have examples on the effect of the single parameters.

For example showing the images generated with different parameters, different values, etc.

@@ -1,7 +1,7 @@
WorldEngine - the best open-source world generator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "an open-source world generator"?^^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can try to be bold :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change you made further down, going from "is intended to be the best open-source world generator" to "has the goal to be the best open-source world generator", it just sounds more humble. I would vote against boldness for the headline.^^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the headline has to be shorter than "is intended to be the best open-source world generator".
I also searched many, many, many, many times for open-source world generator and I could not find any that is comparable to WorldEngine. If I can find one I would change the headline :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this:

WorldEngine - the best open-source world generator*
...
*= Until proven otherwise. :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ah ah, it seems a disclaimer like you see in advertisement :)

@ftomassetti
Copy link
Member Author

Mmmm why this one failed?


======================================================================
FAIL: test_draw_satellite (tests.draw_test.TestDraw)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/Mindwerks/worldengine/tests/draw_test.py", line 161, in test_draw_satellite
    self._assert_img_equal("satellite_28070", target)
  File "/home/travis/build/Mindwerks/worldengine/tests/draw_test.py", line 56, in _assert_img_equal
    drawn_image.array[diff[0][0], diff[0][1]]))
AssertionError: Pixels at 0, 0 are different. Blessed [228 228 255 255], drawn [ 24  95 146 255]
----------------------------------------------------------------------
Ran 42 tests in 422.006s

@tcld
Copy link
Contributor

tcld commented Nov 18, 2015

The problem only occurs for one of the Travis-thingies, looks like the code used for the test is not up-to-date - the blessed pixel shows ice (position and colour hint at it), the drawn pixel shows unfrozen ocean (so the icecap-PR is not yet in the code, it seems).

@ftomassetti
Copy link
Member Author

Rebased and restarted the tests, let's see how it goes

ftomassetti added a commit that referenced this pull request Nov 18, 2015
Preparing documentation for release v0.19.0
@ftomassetti ftomassetti merged commit 187e720 into master Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants